Ticket #10587 (verify: fixed)

Opened 6 years ago

Last modified 5 years ago

Use the convertUnits algorithm in EnginX FitPeaks

Reported by: Lottie Greenwood Owned by: Federico M Pouzols
Priority: major Milestone: Release 3.5
Component: Diffraction Keywords:
Cc: Blocked By:
Blocking: #8368 Tester:

Description (last modified by Federico M Pouzols) (diff)

EnginXFitPeaks currently uses a hard coded equation to translate from dSpacing to Tof. Change it to one already within Mantid.

For implementation - get all fitted dValues to store in vector and then create temporary workspace with those dValues to run convertUnit on, to then extract converted TOF values.

Change History

comment:1 Changed 6 years ago by Lottie Greenwood

  • Status changed from new to assigned

comment:2 Changed 5 years ago by Lottie Greenwood

  • Owner changed from Lottie Greenwood to Federico M Pouzols

comment:3 Changed 5 years ago by Federico M Pouzols

  • Blocking 8368 added

(In #8368) Added new ENGIN-X tickets that have been opened in the last few months as 'blocked by'.

comment:4 Changed 5 years ago by Federico M Pouzols

This seems to be in the method _expectedPeaksInTOF().

comment:5 Changed 5 years ago by Federico Montesino Pouzols

  • Status changed from assigned to inprogress

Use ConvertUnits alg (and others) in _expectedPeaksinTOF, re #10587

Changeset: af59dbec27ff327186fd4827e81ac434b304ef24

comment:6 Changed 5 years ago by Federico Montesino Pouzols

more info on ParentWorkspace, re #10587

Changeset: ae07929f5489c88da00ccc5f6c214bb80cebefa8

comment:7 Changed 5 years ago by Federico Montesino Pouzols

use ConvertUnits wherever possible, re #10587

Changeset: 3438385e545e652bc8be4c99ab7e048212d62b3e

comment:8 Changed 5 years ago by Federico M Pouzols

  • Summary changed from Use convertUnit in EnginX FitPeaks to Use the convertUnits algorithm in EnginX FitPeaks
  • Description modified (diff)
  • Milestone changed from Backlog to Release 3.5

comment:9 Changed 5 years ago by Federico Montesino Pouzols

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #847.

comment:10 Changed 5 years ago by Federico Montesino Pouzols

fix pylint issues, re #10587

Changeset: e8524b944a0185ef73572574888c0859bdb86843

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11429

Note: See TracTickets for help on using tickets.