Ticket #10634 (closed: fixed)
Fixes for IntegratePeaksMD
Reported by: | Owen Arnold | Owned by: | Vickie Lynch |
---|---|---|---|
Priority: | critical | Milestone: | Release 3.4 |
Component: | Diffraction | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Wenduo Zhou |
Description
Here are some issues raised by Pascal. I'll shortly start a discussion to flesh out some of these latter points, but the first two could be started now.
The following two are probably linked to incorrect/insufficient progress reporting.
- The "cancel" button is not working
- The progress bar does not show any progress (stuck at a few percents)
These issues are down to documentation.
- It is difficult to understand what is done to the data from the help.
- The adaptiveQ for instance, if you switch from Q to adaptive Q, you need a completely different set of values. What units is Q in (with 4*pi factor or not ?).
Change History
comment:1 Changed 6 years ago by Nick Draper
- Status changed from new to assigned
- Milestone changed from Release 3.3 to Release 3.4
comment:2 Changed 6 years ago by Vickie Lynch
- Status changed from assigned to inprogress
Refs #10634 progress bar and cancel button fixed
Changeset: 4c1745dad80bfded0ea1326cb62dba3eca76f8ed
comment:3 Changed 6 years ago by Vickie Lynch
Refs #10634 fix doc files
Changeset: 13a5b85c486f4ae140f7a9dfa2f23ec6ca524331
comment:4 Changed 6 years ago by Vickie Lynch
- Status changed from inprogress to verify
- Resolution set to fixed
To test use script with SystemTest file and notice progress bar and try cancelling IntegratePeaksMD. Also check IntegratePeaksMD-v2.html for changes.
Load(Filename='TOPAZ_3132_event.nxs', OutputWorkspace='TOPAZ_3132_event', LoaderName='LoadEventNexus', LoaderVersion=1, LoadMonitors=True) ConvertToMD(InputWorkspace='TOPAZ_3132_event', QDimensions='Q3D', dEAnalysisMode='Elastic', Q3DFrames='Q_sample', LorentzCorrection=True, OutputWorkspace='TOPAZ_3132_md', MinValues='-25,-25,-25', MaxValues='25,25,25', SplitInto='2', SplitThreshold=50, MaxRecursionDepth=13, MinRecursionDepth=7) FindPeaksMD(InputWorkspace='TOPAZ_3132_md', PeakDistanceThreshold=0.37680000000000002, MaxPeaks=50, DensityThresholdFactor=100, OutputWorkspace='TOPAZ_3132_peaks') FindUBUsingFFT(PeaksWorkspace='TOPAZ_3132_peaks', MinD=3, MaxD=15, Tolerance=0.12) IndexPeaks(PeaksWorkspace='TOPAZ_3132_peaks', Tolerance=0.12, NumIndexed=50, AverageError=0.011554102677988988) ShowPossibleCells(PeaksWorkspace='TOPAZ_3132_peaks', NumberOfCells=3, AllowPermutations=False) SelectCellOfType(PeaksWorkspace='TOPAZ_3132_peaks', CellType='Orthorhombic', Apply=True, NumIndexed=50, AverageError=0.011554102677988971) IntegratePeaksMD(InputWorkspace='TOPAZ_3132_md',CoordinatesToUse='Q (sample frame)',PeakRadius='0.1',PeaksWorkspace='TOPAZ_3132_peaks',OutputWorkspace='TOPAZ_3132_peaks_sphere')
comment:5 Changed 6 years ago by Wenduo Zhou
- Status changed from verify to verifying
- Tester set to Wenduo Zhou
comment:6 Changed 6 years ago by Wenduo Zhou
The reported issues can be fixed by this ticket. Thus it is closed.
comment:8 Changed 6 years ago by Wenduo Zhou
Merge remote-tracking branch 'origin/feature/10634_fixes_IntegratePeaksMD'
Full changeset: 0785ed1100dd46f90c2cb5b9f6dd2fb3843cfb1d
Too tight to the code freeze for 3.3, moved to 3.4