Ticket #10641 (verify: wontfix)
Add proper shape types to CalcCorr UI
| Reported by: | Dan Nixon | Owned by: | Dan Nixon |
|---|---|---|---|
| Priority: | major | Milestone: | Backlog |
| Component: | Indirect Inelastic | Keywords: | |
| Cc: | spencer.howells@… | Blocked By: | #10094 |
| Blocking: | Tester: |
Description
Spencer has mentioned some changes to the Calculate Corrections GUI that make setting the sample shape and dimensions easier:
Sample shape options to be Flat, Cylinder & Annulus
Both Cylinder & Annulus use the Cyl prog.
For Cylinder : gui has 'Radius 1' and 'Can radius' and the parameters are r1=0.0, r2='Radius 1', r3='can radius'
For Annulus : gui has 'Radius 1' & 'Radius 2' and 'Can radius' and the parameters are r1='Radius 1', r2='Radius 2', r3='can radius' (ie as it is now for Cyl)
Change History
comment:5 Changed 6 years ago by Dan Nixon
Must be tested on Windows with Mantid built in Release mode.
To test:
- Open Indirect > Data Analysis > Calculate Corrections
- Select sample irs26176_graphite002_red.nxs (systemtests/Data)
- Select can irs26173_graphite002_red.nxs (systemtests/Data)
- Select Shape: Cylinder
- Enter Radius 1: 0.2
- Enter common params (see below)
- Run
- Select Shape: Annulus
- Enter Radius 1: 0
- Enter Radius 1: 0.2
- Enter common params (see below)
- Run (this is effectively a cylinder as the internal radius is zero)
- Check the workspaces match using CheckWorkspacesMatch('irs26176_graphite002_ann_Abs', 'irs26176_graphite002_cyl_Abs', tolerance=1e-10)
- Attempt to use both corection workspaces on Apply Corrections using same sample and can and appropriate geometry
Common params:
- Step size: 0.005
- Beam width: 2.1
- Sample number density: 0.1
- Sample cross sections from: Formula: H2-O
- Can number density: 0.1
- Can cross sections from: Formula: V
comment:6 Changed 6 years ago by Dan Nixon
Use _ann_ naming for annulus, support on apply corr
Refs #10641
Changeset: 7107ec9edc630d67a06536aec6b75795d4f88f5c
comment:8 Changed 6 years ago by Dan Nixon
Merge branch 'master' into feature/10641_calccorr_shape_support
Conflicts:
Code/Mantid/scripts/Inelastic/IndirectAbsCor.pya
Refs #10641
Changeset: 4228a7a8d6755173c4c4ef56ddf6b2b1a55fcb8f
comment:9 Changed 6 years ago by Dan Nixon
- Milestone changed from Release 3.3 to Backlog
Not likely to happen this release.
comment:11 Changed 6 years ago by Dan Nixon
- Status changed from inprogress to verify
- Resolution set to wontfix
The recent work on corrections have made this invalid.
comment:12 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 11483
