Ticket #10657 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

CreateSampleWorkspace with incorrect bin width crashes Mantid

Reported by: Alex Buts Owned by: Nick Draper
Priority: critical Milestone: Release 3.3
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Harry Jeffery

Description

Run script (or fill in appropriate parameters from GUI) 

mono_ws = CreateSampleWorkspace(NumBanks=1, BankPixelWidth=4, NumEvents=10000,XUnit='DeltaE',XMin=-5,XMax=15)

Mantid Dies.

The problem is caused by missing parameter BinWidth having default value 200 in this case. If the value is explicitly set up to 0.1 (physical in this case) everything is ok, but incorrect (default) value should not kill Manitd.

Change History

comment:1 Changed 6 years ago by Nick Draper

  • Owner set to Nick Draper
  • Status changed from new to assigned

comment:2 Changed 6 years ago by Nick Draper

  • Status changed from assigned to inprogress

re #10657 added protection around xmin and xmax values + unit test

Changeset: 918da905b467b89cffdc3acfbbf336c740b4772b

comment:3 Changed 6 years ago by Nick Draper

to test

Run the script above

comment:4 Changed 6 years ago by Nick Draper

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:5 Changed 6 years ago by Harry Jeffery

  • Status changed from verify to verifying
  • Tester set to Harry Jeffery

comment:6 Changed 6 years ago by Harry Jeffery

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/10657_CreateSampleWorkspaceCrash'

Full changeset: ​b13dbbf988756d89d7b372c59f5ca524489ef884

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11499

Note: See TracTickets for help on using tickets.