Ticket #10676 (closed: fixed)
Verify pard_mask_file, hard_mask_plus and hard_mask_only options work properly
| Reported by: | Alex Buts | Owned by: | Alex Buts |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.3 |
| Component: | Direct Inelastic | Keywords: | |
| Cc: | Blocked By: | #10705 | |
| Blocking: | #10803 | Tester: | Federico M Pouzols |
Description
Changes to direct interface moved these properties from legacy to mainstream (namely, legacy options are not implemented differently)
I have hopefully fixed their behaviour in system tests, but one have to ensure these triplet works as before (and write unit test to check it).
Change History
comment:3 Changed 6 years ago by Alex Buts
Changes have been erroneously committed under #10674, so please use GIT to analyse the changes in the code. (I have erroneously named the branch as bugfix/10674_hardmaskOpt)
Due to the changes to direct reduction interface new properties descriptors were introduced which provide the behaviour requested and some synonims used to process these properties were removed from Instrument_Properties.xml file.
It is pretty simple ticket to test as the unit test Mantid\scripts\test\DirectPropertyManagerTest.py -> test_hadmask_options shows and verifies the desired behaviour.
comment:4 Changed 6 years ago by Alex Buts
- Status changed from assigned to verify
- Resolution set to fixed
comment:8 Changed 6 years ago by Federico M Pouzols
- Status changed from verify to verifying
- Tester set to Federico M Pouzols
comment:9 Changed 6 years ago by Federico M Pouzols
- Status changed from verifying to closed
Code changes seem fine and well documented. The relevant test passes, I also passed all other tests in case.
Important note: as explained above, the commits of this test went by mistake into ticket number #10674 which was another branch and was merged a few days before. So when passing this ticket I'm merging branch bugfix/10674_hardmaskOpt (see in #10674) which should actually be bugfix/10676_hardmaskOpt.
comment:10 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 11518
