Ticket #10693 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

cut_sqw in mantid

Reported by: Owen Arnold Owned by: Owen Arnold
Priority: blocker Milestone: Release 3.3
Component: Framework Keywords:
Cc: Blocked By: #10530, #10934
Blocking: #8160, #11231 Tester: Roman Tolchenov

Description (last modified by Owen Arnold) (diff)

Pending framework changes here #10530:

Syntax document describes how this will work here: ​https://github.com/mantidproject/documents/blob/master/Design/VATES/MantidHorace/syntax-proposal.md

Change History

comment:1 Changed 6 years ago by Owen Arnold

  • Blocked By 10530 added

comment:2 Changed 6 years ago by Owen Arnold

  • Description modified (diff)

comment:3 Changed 6 years ago by Owen Arnold

  • Status changed from new to assigned

comment:4 Changed 6 years ago by Owen Arnold

  • Status changed from assigned to inprogress

refs #10693. Remove the algorithm parts

Changeset: f378f4be154d6247df8e566eef59c4deb0c6bdd6

comment:5 Changed 6 years ago by Owen Arnold

refs #10693. Doctest and better docs

Changeset: 899ca5023be9df69fb670a419e0b6535129b3bdd

comment:6 Changed 6 years ago by Owen Arnold

refs #10693. Remove the algorithm parts

Changeset: 726ebd85a3f7a4c71f9a3dbd0cd762f75e9dcf2f

comment:7 Changed 6 years ago by Owen Arnold

refs #10693. Doctest and better docs

Changeset: 1e827aa8cddb6784bf38459de2d1eb31ddb36e22

comment:8 Changed 6 years ago by Owen Arnold

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #107.

comment:9 Changed 6 years ago by Owen Arnold

  • Status changed from verify to reopened
  • Resolution fixed deleted

comment:10 Changed 6 years ago by Owen Arnold

  • Status changed from reopened to inprogress

refs #10693. Relax restrictions.

I think these original restrictions made sense, but currently LoadSQW is not loading workspaces in the HKL frame, and therefore this restriction is going to prove a problem for beta testers.

I've set it to be a warning only if AxisCheck=False.

Changeset: fbb888f91dcfdca52e6b9c1bf2eda029a3decba2

comment:11 Changed 6 years ago by Owen Arnold

refs #10693. Change warning message.

Changeset: d80ed4c0b215e261f5ac04590d82cbf13b228af1

comment:12 Changed 6 years ago by Owen Arnold

refs #10693. Remove restrictions

I discussed this with Russell Ewings, and we came to the conclusion that any output from this would only cause confusion.

Changeset: 72d6e149bcea698be4174a615dffc037cc084fa1

comment:13 Changed 6 years ago by Owen Arnold

refs #10693. Remove restrictions

I discussed this with Russell Ewings, and we came to the conclusion that any output from this would only cause confusion.

Changeset: 3948bf8bba4efa10530ed55aeebcbc58bd5f99b3

comment:14 Changed 6 years ago by Owen Arnold

Tester: We are not yet fully compliant with the aforementioned design document, but the first version of this algorithm (marked at runtime as a Beta version) is ready.

Algorithm docs and unit tests give example outputs. This algorithm has also already had some instrument scientist testing.

comment:15 Changed 6 years ago by Owen Arnold

  • Status changed from inprogress to verify
  • Resolution set to fixed
  • Summary changed from cut_sqw in mantid (cloned) to cut_sqw in mantid

comment:16 Changed 6 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:17 Changed 6 years ago by Owen Arnold

  • Status changed from verifying to closed

Merge branch 'feature/10693_cut_md' of github.com:mantidproject/mantid into feature/10693_cut_md

Full changeset: ​ea407194aa1169bd7cf05958feacf3ed0ff0fe1b

comment:18 Changed 6 years ago by Roman Tolchenov

Merge pull request #107 from mantidproject/feature/10693_cut_md

Feature/10693 cut md

Full changeset: ​d820cad1274ff36964152f262890f71c5c84e621

comment:19 Changed 6 years ago by Owen Arnold

  • Blocked By 10934 added

comment:20 Changed 5 years ago by Owen Arnold

  • Blocking 11231 added

comment:21 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11535

Note: See TracTickets for help on using tickets.