Ticket #1069 (closed: fixed)

Opened 11 years ago

Last modified 5 years ago

Test for DetectorEfficiencyCor, 6 hours

Reported by: Steve Williams Owned by: Steve Williams
Priority: major Milestone: Iteration 22
Component: Keywords: Excitations, detectors, corrections, testing
Cc: Blocked By:
Blocking: Tester:

Description

Compile and run the Fortran code suplied by Toby Perring, possibly under Linux, to get a file with detector efficiencies as a function of energy, detector radius, wall thickness pressure and angle. In C++ create a small workspace that will generate the same data in a workspace. Save the workspace and do a file compare with a formated version of the Fortran generated file to check accuracy.

Change History

comment:1 Changed 11 years ago by Steve Williams

  • Status changed from new to accepted

Spend less time on this. Send detector efficiency numbers for an instrument off to Excitations. Calculate the detector efficiencies in part of a MARI workspace and write tests to check that the results don't change.

comment:2 Changed 11 years ago by Steve Williams

  • Status changed from accepted to closed
  • Resolution set to fixed

(In [4180]) The DetectorEfficiencyCor unit test uses current output from the algorithm, as this has had some testing by Jon Taylor. Detector groups are now allowed by the algorithm fixes #1069

comment:3 Changed 11 years ago by Steve Williams

  • Status changed from closed to reopened
  • Resolution fixed deleted

comment:4 Changed 11 years ago by Steve Williams

  • Status changed from reopened to closed
  • Resolution set to fixed

(In [4182]) Remove some compiler warnings fixes #1069

comment:5 Changed 11 years ago by Steve Williams

  • Status changed from closed to reopened
  • Resolution fixed deleted

comment:6 Changed 11 years ago by Steve Williams

(In [4187]) Problems with compiler warning that don't show up on my computer, and some tests that I broke re #1069

comment:7 Changed 11 years ago by Steve Williams

  • Status changed from reopened to testing
  • Resolution set to fixed

comment:8 Changed 11 years ago by Martyn Gigg

  • Status changed from testing to closed

A unit test exists for the algorithm and it appears to be working

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​1917

Note: See TracTickets for help on using tickets.