Ticket #1070 (closed: fixed)

Opened 11 years ago

Last modified 5 years ago

Code review

Reported by: Nick Draper Owned by: Russell Taylor
Priority: critical Milestone: Iteration 21
Component: Keywords:
Cc: Blocked By:
Blocking: Tester:

Description

Please review the following areas of code for Quality and Performance.

LoadRaw (Particularly when lots of periods) LoadLog (3 column format, and 2 column format speed) SaveSPE

Change History

comment:1 Changed 11 years ago by Nick Draper

(In [3585]) re #1070 3014 has 31 periods

comment:2 Changed 11 years ago by Nick Draper

Files added in changeset [3585] may be usefull, it includes a high period count file and a large 3 column log file.

comment:3 Changed 11 years ago by Russell Taylor

  • Status changed from new to accepted

comment:4 Changed 11 years ago by Russell Taylor

(In [3604]) Quick fix to cut time of loading POLREF example .log file from ~6.7s to ~2.2s. More tidying up to come later. Re #1070.

comment:5 Changed 11 years ago by Russell Taylor

(In [3609]) ~Quadruple speed of SaveSPE, largely by using fprintf instead of C++ streams. Re #1070.

comment:6 Changed 11 years ago by Russell Taylor

  • Status changed from accepted to testing
  • Resolution set to fixed

Major performance issues have been resolved. The code quality of LoadRaw & LoadLog could use improving, which would likely result in a minor further improvement in performance.

comment:7 Changed 11 years ago by Martyn Gigg

  • Status changed from testing to closed

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​1918

Note: See TracTickets for help on using tickets.