Ticket #1074 (closed: fixed)

Opened 11 years ago

Last modified 5 years ago

Appallingly slow loading of history from a nexus processed file

Reported by: Russell Taylor Owned by: Roman Tolchenov
Priority: critical Milestone: Iteration 21
Component: Keywords:
Cc: Blocked By:
Blocking: Tester:

Description

The attached file takes about 20 seconds to load, almost all of which is related to the loading of the algorithm history. I've worked out exactly where the problem is, but I don't know enough about the nexus library, or more particularly our wrappers around it, to work out how to fix it.

The problem lines are lines 415 & 416 of LoadNexusProcessed.cpp, which, within the enclosing loop, each account for ~10 seconds of the algorithm duration:

  NXNote entry = history.openNXNote(itr->nxname);
  const std::vector<std::string> & info = entry.data();

The underlying slow method behind the first line is NXClass::openNXClass, that behind the second line is NXClass::openNXChar. I think they both wind up calling the NXClass::open method.

Attachments

van_s2_new_corr-0.nxs (994.5 KB) - added by Russell Taylor 11 years ago.

Change History

Changed 11 years ago by Russell Taylor

comment:1 Changed 11 years ago by Nick Draper

  • Status changed from new to assigned
  • Owner set to Roman Tolchenov

comment:2 Changed 11 years ago by Roman Tolchenov

(In [3627]) Should work faster now. re #1074

comment:3 Changed 11 years ago by Roman Tolchenov

  • Status changed from assigned to testing
  • Resolution set to fixed

comment:4 Changed 11 years ago by Martyn Gigg

  • Status changed from testing to closed

comment:5 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 1922

comment:6 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 1922

Note: See TracTickets for help on using tickets.