Ticket #10768 (closed: fixed)
Expose in Python Goniometer Matrix setter / getter
Reported by: | Ricardo Leal | Owned by: | Ricardo Leal |
---|---|---|---|
Priority: | major | Milestone: | Release 3.3 |
Component: | Framework | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Andrei Savici |
Description
The Goniometer only has exposed the method
getEulerAngles
Need to expose:
getR()
and
setR(Kernel::DblMatrix newR)
Where R is the Global rotation matrix of the goniometer.
Change History
comment:2 Changed 6 years ago by Ricardo M. Ferraz Leal
- Status changed from assigned to inprogress
Added setR getR and python test Re #10768
Changeset: ec0b45cb6ffc57684c97f2d0b6f37634b278a73c
comment:3 Changed 6 years ago by Ricardo M. Ferraz Leal
Added better tests Re #10768
Changeset: ba8923e5a815801a0d343f961ca1d8e327af33f6
comment:4 Changed 6 years ago by Ricardo Leal
To test, run:
ctest --output-on-failure -R PythonInterfaceGeometry_GoniometerTest
or play with the python shell for a given workspace ws :
g = ws.getRun().getGoniometer() print g.getR() r = np.array([(1., 0., 0.), (0., 0., 1.), (0., -1., 0.)]) g.setR(r) print g.getR()
comment:5 Changed 6 years ago by Ricardo Leal
- Status changed from inprogress to verify
- Resolution set to fixed
comment:6 Changed 6 years ago by Andrei Savici
- Status changed from verify to verifying
- Tester set to Andrei Savici
comment:7 Changed 6 years ago by Ricardo M. Ferraz Leal
setR Initiliases axes. Exposed axesInfo. Re #10768
Changeset: 3aec64490abefaf672c4fa7b144c18737570265b
comment:8 Changed 6 years ago by Ricardo Leal
New setR:
void Goniometer::setR(Kernel::DblMatrix rot){ motors.clear(); R = rot; initFromR=true; }
comment:9 Changed 6 years ago by Ricardo M. Ferraz Leal
Added setR getR and python test Re #10768
Changeset: d107a233430073ac78373f08cee84f542bf4b067
comment:10 Changed 6 years ago by Ricardo M. Ferraz Leal
Added better tests Re #10768
Changeset: ac6325baab721d058175084db40b28df60e1f6b2
comment:12 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 11610
Is this really needed for R3.3, if not them please move the milestone.