Ticket #10799 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

future.pyplot not getting packaged

Reported by: Owen Arnold Owned by: Federico M Pouzols
Priority: blocker Milestone: Release 3.3
Component: Framework Keywords:
Cc: martyn.gigg@… Blocked By: #8912
Blocking: Tester: Martyn Gigg

Description (last modified by Owen Arnold) (diff)

Major issue (but easy fix) that somehow got though unscripted testing prior to beta testing!

  • Download a nightly build of Mantid
  • Install and open the aforementioned MantidPlot instance and run this in the script window
    from pymantidplot.future.pyplot import *
    
  • You get an import error
    ImportError: No module named future.pyplot
      at line 1 in 'New script'
    

Looks like subdirectories of the package are not being copied over.

Change History

comment:1 Changed 6 years ago by Owen Arnold

  • Cc martyn.gigg@… added
  • Status changed from new to assigned
  • Description modified (diff)

comment:2 Changed 6 years ago by Federico Montesino Pouzols

  • Status changed from assigned to inprogress

ship files inside pymantiplot.future with manual install(), re #10799

Changeset: 5bf9ce8fb1478c274f9b9e3d15bc390ba9b611e7

comment:3 Changed 6 years ago by Federico M Pouzols

  • Status changed from inprogress to verify
  • Resolution set to fixed

I think this is now fixed, the missing files are now installed explicitly, using install() similarly as the pymantiplot and ipython files. All the platforms seem to be happy with the changes. To test there are different alternatives:

  • make sure that the following files are included in the generated package (inside bin/pymantidplot/future): pyplot.py, pyplot.pyc, __init__.py, __init__.pyc) when you build it with cpack.
  • install the package (or, as an alternative one of the latest develop_incremental packages) and check that you can do
    from pymantidplot.future.pyplot import *
    

as in the ticket description but without errors. This is the real test, and implies that the next point should be fine:

comment:4 Changed 6 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:5 Changed 6 years ago by Martyn Gigg

  • Status changed from verifying to closed

comment:6 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 11641

Note: See TracTickets for help on using tickets.