Ticket #10817 (closed: fixed)
Subtle bug in harmaskPlus/hardmaskOnly legacy options
Reported by: | Alex Buts | Owned by: | Alex Buts |
---|---|---|---|
Priority: | blocker | Milestone: | Release 3.3 |
Component: | Direct Inelastic | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Martyn Gigg |
Description
A subtle bug found in harmaskPlus/hardmaskOnly implementation.
These properties work by setting use_hard_mask_only/hard_mask_file options appropriately, but for efficiency they are currently implemented without accessing these properties setters.
As the result, changing these properties is not recorded in changed properties values and new workspace can overwrite these properties values if have them different from default.
Change History
comment:2 Changed 6 years ago by Alex Buts
Re #10817 minor comments
Changeset: 064f8392b632486e74917123cf2be58e1c202d45
comment:3 Changed 6 years ago by Alex Buts
Re #10817 Resolving conflicts with #10803
Merge branch 'bugfix/10817_errorHardmaskPlus' into develop
Conflicts:
Code/Mantid/scripts/Inelastic/Direct/PropertyManager.py
Changeset: c6bacaff7e36daae230ec7ee4a6e574e0153ec89
comment:4 Changed 6 years ago by Alex Buts
Re #10817 Minor bug in DirectEnergyConversion
(header not defined if scrip fails)
Changeset: ac88336cea5f457f413a440ef8c50f82b4a3bc07
comment:5 Changed 6 years ago by Alex Buts
Re #10817 Lost in branches changes to DirectPropertyManager
Changeset: 471842f177182ea4b4987742e549f3efa4900329
comment:6 Changed 6 years ago by Alex Buts
Re #10817 lost changes again
Changeset: d7f3b3fe8ccf6ee587b33154e906654b7694a6ff
comment:8 Changed 6 years ago by Alex Buts
- Status changed from assigned to verify
- Resolution set to fixed
comment:9 Changed 6 years ago by Martyn Gigg
- Status changed from verify to verifying
- Tester set to Martyn Gigg
comment:10 Changed 6 years ago by Martyn Gigg
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/bugfix/10817_errorHardmaskPlus'
Full changeset: f51599043dfa5a7f910735d86c07d81443684c07
comment:11 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 11659
Re #10817 This should fix it
Changeset: b141209d739eb447332b6d449304d5f0847854c5