Ticket #10828 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Slits Calculator

Reported by: Owen Arnold Owned by: Harry Jeffery
Priority: critical Milestone: Release 3.4
Component: Reflectometry Keywords:
Cc: Blocked By:
Blocking: Tester: Owen Arnold

Description

Should be done early in release for 3.3

  • New menu option for Utilities
  • Dialog for the slits calculator
  • Code attached

Attachments

slitsCalculator.zip​ (7.8 KB) - added by Owen Arnold 6 years ago.

Change History

Changed 6 years ago by Owen Arnold

comment:1 Changed 6 years ago by Owen Arnold

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Owen Arnold 

If you could also create a dummy entry in the new 'Utilities' menu on the Refl_GUI, named something like "Qc calculator" that would be great.
Please let me know if you need further information.

comment:3 Changed 6 years ago by Harry Jeffery

  • Summary changed from Slits Calculator Wanted on old ReflGUI to Slits Calculator
  • Milestone changed from Release 3.3 to Release 3.4

comment:4 Changed 6 years ago by Owen Arnold

As already mentioned. It would be good if there was code-reuse between this and CalculateResolution() algorithm. If that means creating an algorithm which gave the slits position, that would be worth doing.

comment:5 Changed 6 years ago by Harry Jeffery

  • Status changed from assigned to inprogress

comment:6 Changed 6 years ago by Harry Jeffery

Refs #10828 Create slit calculator widget

Changeset: a835e2c44cdaf96a2876523df4f89da6067d9179

comment:7 Changed 6 years ago by Harry Jeffery

Refs #10828 Add slit calculator to new Refl UI

Changeset: a221f822ee8e21179814a0e3015b8ec2c16f51b7

comment:8 Changed 6 years ago by Harry Jeffery

Refs #10828 Don't use qmath in slit calculator

Changeset: d4f2299df6a1ab5c03fe6dd2fbb031584d2d6821

comment:9 Changed 6 years ago by Harry Jeffery

Refs #10828 Add CalculateSlits algorithm

Changeset: 4c11d71209d297d2d34d29cfe12e3df01ad9c20f

comment:10 Changed 6 years ago by Harry Jeffery

Refs #10828 Use CalculateSlits algorithm in slit calculator

Changeset: d00a987452dfbc676db693885fdfa37df84be2d4

comment:11 Changed 6 years ago by Harry Jeffery

Refs #10828 Add SlitCalculator dialog to old refl gui

Changeset: 8094470ffacbd38f0c16c08d0956911248d648ef

comment:12 Changed 6 years ago by Harry Jeffery

TODO

  • Write documentation
  • Get instrument scientists to clarify footprint and s2sa
Last edited 6 years ago by Harry Jeffery (previous) (diff)

comment:13 Changed 6 years ago by Harry Jeffery

Refs #10828 Unify indentation in widgets CMakeLists

Changeset: 8a38016eb6a15b4024db80e310080cf11c2d9095

comment:14 Changed 6 years ago by Harry Jeffery

Refs #10828 Document CalculateSlits

Changeset: 8744b193fd579e2de3f2ce3e81b84eac3669082f

comment:15 Changed 6 years ago by Harry Jeffery

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #197.

comment:16 Changed 6 years ago by Harry Jeffery

Jenkins, retest this please.

comment:17 Changed 6 years ago by Harry Jeffery

Jenkins, retest this please.

comment:18 Changed 6 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:19 Changed 6 years ago by Owen Arnold

If it's OK with you Jean, I'd like to verify this one.

comment:20 Changed 6 years ago by Owen Arnold

All looks working as expected. Please add a section about the slit calculator here http://www.mantidproject.org/ISIS_Reflectometry_GUI.

comment:21 Changed 6 years ago by Owen Arnold

  • Status changed from verifying to closed

Merge pull request #197 from mantidproject/feature/10828_slits_calculator

Add slit calculator

Full changeset: ​5d9e8cdbb89398d794f361295efb7c8d2ed9a64e

comment:22 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11670

Note: See TracTickets for help on using tickets.