Ticket #10830 (new)

Opened 6 years ago

Last modified 5 years ago

Improve efficiency, code quality and usability of MDNormDirectSC

Reported by: Alex Buts Owned by: Andrei Savici
Priority: major Milestone: Backlog
Component: Framework Keywords:
Cc: Blocked By: #10829
Blocking: Tester:

Description (last modified by Alex Buts) (diff)

This is mainly thought which can be spread into separate tickets or dealt all together

1) Why to calculate detector positions in the algorithm when convertToMD have just calculated them using PreprocessDetectorsToMd and placed them into separate workspace for further usage? It is expensive operation.

2) Enable OMP in the algorithm (after logical bugs are fixed)

3) in 90% of cases one wants to obtain normalized workspace of the size of the source workspace. Why to combine MDNormDirectSC with rebin and allow it to work on part of the workspace? If this feature is important, at least the algorithm with empty dimension parameters should pick up binning ranges from source workspace.

4) Create meaningful unit test for the algorithm

Change History

comment:1 Changed 6 years ago by Alex Buts

  • Blocked By 10829 added

comment:2 Changed 6 years ago by Alex Buts

  • Description modified (diff)

comment:3 Changed 6 years ago by Andrei Savici

Usage example for MDNormDirectSC. Refs #10829

Also enabled the parallel processing. Refs #10830

Changeset: e9e0dd6659761abae296e5ed10a8f99928625887

comment:4 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11672

Note: See TracTickets for help on using tickets.