Ticket #10833 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

CalculateResolution's failure is unhandled by the ISIS Refl Polref UI

Reported by: Harry Jeffery Owned by: Harry Jeffery
Priority: major Milestone: Release 3.4
Component: GUI Keywords:
Cc: Blocked By:
Blocking: Tester: Dan Nixon

Description

If CalculateResolution fails, its default value (8.9e+307) is used instead of aborting.

Instead, processing should be aborted.

Change History

comment:1 Changed 6 years ago by Harry Jeffery

Refs #10833 Abort if CalculateResolution fails

Changeset: 97cda828a984b9712fe559dec246b0d5796c53f7

comment:2 Changed 6 years ago by Peter Peterson

  • Owner set to Harry Jeffery
  • Status changed from new to assigned

comment:3 Changed 6 years ago by Harry Jeffery

  • Status changed from assigned to inprogress

comment:4 Changed 6 years ago by Harry Jeffery

Testing

  • Load OFFSPEC00027585
  • Open the ISIS Reflectometry (Polref) interface.
  • Enter OFFSPEC00027585 into the Run(s) column, and 0.35 into the Angle column.
  • Hit process.
    • Processing should fail, with an error message saying to specify dQ/Q manually.
Last edited 6 years ago by Harry Jeffery (previous) (diff)

comment:5 Changed 6 years ago by Harry Jeffery

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:6 Changed 6 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:7 Changed 6 years ago by Roman Tolchenov

  • Status changed from verifying to reopened
  • Resolution fixed deleted

Entering 1 into dQ/Q dives another fail message. MantidPlot hangs when you try to close it.

comment:8 Changed 6 years ago by Harry Jeffery

  • Status changed from reopened to verify
  • Resolution set to fixed

Ah, that wasn't the best example, as processing OFFSPEC data has other problems, being addressed by #10585.

The scope of this ticket was just to give an informative error message when CalculateResolution fails, as the example demonstrates. I should have explained about the other errors if a value if given. It is odd though that the algorithm is hanging Mantid, and I'll look into that in #10585.

This ticket should still be fine to merge though.

comment:9 Changed 6 years ago by Roman Tolchenov

I cannot see from the description of #10585 how it will address the issue in comment7. Could you please make it clearer?

comment:10 Changed 6 years ago by Harry Jeffery

The processing failure for the OFFSPEC data is due to missing parameters and some components in the IDF being named unusually.

With this in the options column it ought to succeed:

DetectorComponentName="HeDetector", SampleComponentName="sampleholder", MonitorBackgroundWavelengthMin=15, MonitorBackgroundWavelengthMax=20, MonitorIntegrationWavelengthMin=2, MonitorIntegrationWavelengthMax=14, I0MonitorIndex=1, ProcessingInstructions="3"

The tickets have been re-jigged slightly, so the changes to the IDF/parameter files that make those options unnecessary are being introduced in #10658

comment:11 Changed 6 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester changed from Roman Tolchenov to Owen Arnold

comment:12 Changed 6 years ago by Owen Arnold

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/10833_calculate_resolution_failure'

Full changeset: ff57c95b281144df61d1fdf25e08b75cb07e3c26

comment:13 Changed 6 years ago by Owen Arnold

Fails as I would expect it to.

comment:14 Changed 6 years ago by Anton Piccardo-Selg

Refs #10833 Remove rebin button

Changeset: 5c7faf446492657b9ca1672c06150b1805624b3f

comment:15 Changed 6 years ago by Anton Piccardo-Selg

Refs #10833 Remove creation slot for rebinning cutter filter

Changeset: 48dc62e49926cda0c629ff3b62a3eb5da8a4f3a2

comment:16 Changed 6 years ago by Anton Piccardo-Selg

Refs #10833 Remove rebinning code from StandardView

Changeset: 14f01219323afc19c545f7b2cbe8e17235a937af

comment:17 Changed 6 years ago by Anton Piccardo-Selg

Refs #10833 Remove rebin in rest of VatesSimpleGuiViewWidgets

Changeset: 467b1f5536d591ac0b63d361ba43d91a922263af

comment:18 Changed 6 years ago by Anton Piccardo-Selg

Refs #10833 Remove the object panel for the rebinning cutter

Changeset: 131a8263cf767210da129952026d01df9a1884cc

comment:19 Changed 6 years ago by Anton Piccardo-Selg

Refs #10833 Remove object panel for rebinning transform

Changeset: 21a5414f16057afddb89ddf1a6cb9ba14c7dfbfd

comment:20 Changed 6 years ago by Anton Piccardo-Selg

Refs #10833 Remove rebinning transform operator

Changeset: 354e3fb826ad5a86d71e196eae6ed48062b72f27

comment:21 Changed 6 years ago by Anton Piccardo-Selg

Refs #10833 Remove rebinning cutter operator

Changeset: a358c3c2799bd537ca4efe3157de8ad30c00b63b

comment:22 Changed 6 years ago by Anton Piccardo-Selg

Refs #10833 Change Cmake files to account for plugin deletions

Changeset: fa69402268a57b9478cf09431b488c54eb75bbae

comment:23 Changed 6 years ago by Anton Piccardo-Selg

Refs #10833 Remove all RebinningPresenters

Changeset: e9ec9d8ec222e0a97165353067f970aaf51f98a5

comment:24 Changed 6 years ago by Anton Piccardo-Selg

Refs #10833 Remove rebinning action manager

Changeset: 31ea1526d09f80506140efff5620f40e0ba4611f

comment:25 Changed 6 years ago by Anton Piccardo-Selg

Refs #10833 Remove rebinning view

Changeset: 6f0e8d1eace22fbb51bbb8eeaa5c009cc5a0ce28

comment:26 Changed 6 years ago by Anton Piccardo-Selg

Refs #10833 Remove clipper

Changeset: 212d4894830fd6c5d1aae1e5ec60c1edf04c0240

comment:27 Changed 6 years ago by Anton Piccardo-Selg

Refs #10833 Renaming the xml definitions for vates

Changeset: d43633040196864e4ac5453db3f7d83a57a84cef

comment:28 Changed 6 years ago by Anton Piccardo-Selg

Refs #10833 Rename knowledge serializer

Changeset: 023bb9504bc43e97bf9a1cd20f0d4bda5a0fcb9c

comment:29 Changed 6 years ago by Anton Piccardo-Selg

Refs #10833 Adding a rebin dialog and manager

Changeset: 98a637ca8fe1d80e8fb7f213a9677f9008a876a7

comment:30 Changed 6 years ago by Anton Piccardo-Selg

Refs #10833 Clear RebinningCutter reference in tests

Changeset: b29a7ee96130b063d637955030b113cdce2ffb6a

comment:31 Changed 6 years ago by Anton Piccardo-Selg

Refs #10833 Changed rebinning in the vsi

Changeset: 02deb399ee6db7e0567bec01c1e00a856dccf5f8

comment:32 Changed 6 years ago by Anton Piccardo-Selg

Refs #10833 Fix button issue

Changeset: f455fa8da7d0ce5642b3fe58f716a9e3b0b1d3c4

comment:33 Changed 6 years ago by Anton Piccardo-Selg

  • Status changed from closed to verify

This is being verified as pull request #209.

comment:34 Changed 6 years ago by Anton Piccardo-Selg

Jenkins, retest this please

comment:35 Changed 6 years ago by Anton Piccardo-Selg

Jenkins, retest this please.

comment:36 Changed 6 years ago by Anton Piccardo-Selg

Jenkins, retest this please

comment:37 Changed 6 years ago by Anton Piccardo-Selg

Jenkins, retest this please

comment:38 Changed 6 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester changed from Owen Arnold to Roman Tolchenov

comment:39 Changed 6 years ago by Roman Tolchenov

  • Tester changed from Roman Tolchenov to Owen Arnold

Github assigned me to this ticket by mistake instead of #10883. Returning testing to Owen.

comment:40 Changed 6 years ago by Roman Tolchenov

@picatess Could you merge master and resolve the conflicts please?

comment:41 Changed 6 years ago by Anton Piccardo-Selg

@mantid-roman Master is merged and the conflicts are resolved.

comment:42 Changed 6 years ago by Federico M Pouzols

  • Milestone changed from Release 3.3 to Release 3.4

I was going through the tickets list and noticed that this was labeled as "3.3" here on trac, so updating to "3.4".

comment:43 Changed 6 years ago by Anton Piccardo-Selg

Jenkins, retest this please

comment:44 Changed 6 years ago by Anton Piccardo-Selg

Jenkins, retest this please

comment:45 Changed 6 years ago by Anton Piccardo-Selg

@mantid-roman 1-5 are handled, 6 I could not reproduce

comment:46 Changed 6 years ago by Roman Tolchenov

  • Status changed from verifying to closed

Merge pull request #209 from mantidproject/feature/10833_rework_rebinning_for_vsi

Remove the RebinningCutter from the VSI

Full changeset: 80c7a0ecb4e916c2952c433bf8bb3fbef0d3dda7

comment:47 Changed 6 years ago by Roman Tolchenov

  • Status changed from closed to reopened
  • Resolution fixed deleted

The pull request for #10883 closed this ticket by mistake.

comment:48 Changed 6 years ago by Harry Jeffery

  • Status changed from reopened to verify
  • Resolution set to fixed

This ticket had already been closed, so it can be left closed: see https://github.com/mantidproject/mantid/commit/ff57c95b281144df61d1fdf25e08b75cb07e3c26

comment:49 Changed 6 years ago by Dan Nixon

  • Status changed from verify to verifying
  • Tester changed from Owen Arnold to Dan Nixon

comment:50 Changed 6 years ago by Dan Nixon

  • Status changed from verifying to closed

comment:51 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 11675

Note: See TracTickets for help on using tickets.