Context Navigation

← Previous Ticket
Next Ticket →

Ticket #10840 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

fix rpath issues with osx package built cmake 3

Reported by:	Steven Hahn	Owned by:	Steven Hahn
Priority:	major	Milestone:	Release 3.4
Component:	Framework	Keywords:
Cc:		Blocked By:
Blocking:		Tester:	Pete Peterson

Description

In cmake 3, MACOSX_RPATH is enabled by default and is currently generating a large warning. Determine if we want MACOSX_RPATH enabled and we do want it enabled, specify it for each target.

Change History

comment:1 Changed 6 years ago by Steven Hahn

CMake Warning (dev):
  Policy CMP0042 is not set: MACOSX_RPATH is enabled by default.  Run "cmake
  --help-policy CMP0042" for policy details.  Use the cmake_policy command to
  set the policy and suppress this warning.

  MACOSX_RPATH is not specified for the following targets:

   API
   Algorithms
   Crystal
   CurveFitting
   CustomDialogs
   CustomInterfaces
   DataHandling
   DataObjects
   DesignerPlugins
   Geometry
   ICat
   ISISLiveData
   Kernel
   LiveData
   MDAlgorithms
   MDEvents
   MantidQtAPI
   MantidQtFactory
   MantidQtRefDetectorViewer
   MantidQtSliceViewer
   MantidQtSpectrumViewer
   MantidWidgets
   Nexus
   PythonAPIModule
   PythonGeometryModule
   PythonKernelModule
   PythonWorkspaceCreationHelper
   QtPropertyBrowser
   RemoteAlgorithms
   SINQ
   ScriptRepository
   UserAlgorithms
   WorkflowAlgorithms

This warning is for project developers.  Use -Wno-dev to suppress it.

comment:2 Changed 6 years ago by Steven Hahn

cmake --help-policy CMP0042
CMP0042
-------

``MACOSX_RPATH`` is enabled by default.

CMake 2.8.12 and newer has support for using ``@rpath`` in a target's install
name.  This was enabled by setting the target property
``MACOSX_RPATH``.  The ``@rpath`` in an install name is a more
flexible and powerful mechanism than ``@executable_path`` or ``@loader_path``
for locating shared libraries.

CMake 3.0 and later prefer this property to be ON by default.  Projects
wanting ``@rpath`` in a target's install name may remove any setting of
the ``INSTALL_NAME_DIR`` and ``CMAKE_INSTALL_NAME_DIR``
variables.

This policy was introduced in CMake version 3.0.  CMake version
3.0.2 warns when the policy is not set and uses OLD behavior.  Use
the cmake_policy command to set it to OLD or NEW explicitly.

comment:3 Changed 6 years ago by Steven Hahn

Refs #10840. MantidPlot starts, but still has issues with python.

Changeset: 6b37331ae2752d3373be29d3e8d516a6fb739b6b

comment:4 Changed 6 years ago by Steven Hahn

Refs #10840. Python imports without errors.

Changeset: b332d1f20ca967bbe14c04b28b01a9c67ef26781

comment:5 Changed 6 years ago by Steven Hahn

Refs #10840. Libraries copied to bundle but crashes on start.

Changeset: 7eb1127039f29029f4958a7372e66326e24a457a

comment:6 Changed 6 years ago by Steven Hahn

Refs #10840. MantidPlot starts, but still has issues with python.

Changeset: f2d6a4dfa83bc425df6b208ecd8b7b0404315b56

comment:7 Changed 6 years ago by Steven Hahn

Refs #10840. Python imports without errors.

Changeset: e26b356fc2449a4eac10638f880ab095231ccd0a

comment:8 Changed 6 years ago by Steven Hahn

Refs #10840. homebrew dependencies included in app bundle.

Changeset: 739a169829a26e2447c604a9eeb5ba6ccea4e6cd

comment:9 Changed 6 years ago by Steven Hahn

Refs #10840. update sip and pyqt versions. Needs more general fix.

Changeset: a1bf9167796efa053531577ad2ca2281819a5d0e

comment:10 Changed 6 years ago by Steven Hahn

Refs #10840. Added python dependencies

Changeset: 263d13a6bcc71345740c74fe2ed942e25aeddcf5

comment:11 Changed 6 years ago by Steven Hahn

Refs #10840. Adding comments to ruby file creating app bundle

Changeset: 7ae850ccc006d5a2f64484de73d307de36a550af

comment:12 Changed 6 years ago by Steven Hahn

Refs #10840. adding file that runs ruby script.

Changeset: 9ea16158a53f271bcfbe0f477821acf8ab4e9234

comment:13 Changed 6 years ago by Steven Hahn

Refs #10840. Update DarwinBuild so it works in 10.8 and 10.9

Changeset: 85b037c86f6b66610b54a5def153928beb78d171

comment:14 Changed 6 years ago by Steven Hahn

Refs #10840. Fix readlink issue

Changeset: 1a17d915875607585e647a84d4143104bd8ecda2

comment:15 Changed 6 years ago by Steven Hahn

Refs #10840. Get working with other systems

Changeset: e84647ff1291c0a5acc6cc76977fe4d37ddc451b

comment:16 Changed 6 years ago by Steven Hahn

Status changed from new to verify
Resolution set to fixed

This is being verified as pull request #137.

comment:17 Changed 6 years ago by Steven Hahn

Refs #10840. fix qt imageformats libraries

Changeset: db817eafbeb9ca0aae807640202e0581e890fc55

comment:18 Changed 6 years ago by Steven Hahn

Refs #10840. return to 10.8 deployment target. change id on libqsqlite

Changeset: c11ba6254f6d47e92d50a3f76de3826cf4ae7484

comment:19 Changed 6 years ago by Steven Hahn

Refs #10840. add missing if around INSTALL_RPATH

Changeset: 7c489179cd28674d0619fb95872a1036380c8a0f

comment:20 Changed 6 years ago by Steven Hahn

retest this please

comment:21 Changed 6 years ago by Steven Hahn

retest this please

comment:22 Changed 6 years ago by Steven Hahn

retest this please

comment:23 Changed 6 years ago by Steven Hahn

retest this please

comment:24 Changed 6 years ago by Steven Hahn

I don't know why the pull request build failed. The issue appears to be related to git and not the cod changes in this branch. Also, these changes are in develop, which is passing.