Ticket #10850 (closed: fixed)
Remove the Verbose option from indirect UIs
Reported by: | Dan Nixon | Owned by: | Dan Nixon |
---|---|---|---|
Priority: | major | Milestone: | Release 3.4 |
Component: | Indirect Inelastic | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Martyn Gigg |
Description
Really this should just be done using different log levels (and it pretty much is in a lot of the newer algorithms).
Change History
comment:3 Changed 6 years ago by Dan Nixon
Remove Verbose options from algorithms
Replace with appropriate logging levels
Refs #10850
Changeset: 6c02875073f0b2df615843ba346e9e53873bcee4
comment:10 Changed 6 years ago by Dan Nixon
Merge branch 'master' into feature/10850_remove_indirect_verbose_option
Conflicts:
Code/Mantid/MantidQt/CustomInterfaces/inc/MantidQtCustomInterfaces/IndirectDataAnalysis.ui Code/Mantid/MantidQt/CustomInterfaces/inc/MantidQtCustomInterfaces/IndirectDataReduction.ui Code/Mantid/MantidQt/CustomInterfaces/src/Indirect/ApplyCorr.cpp Code/Mantid/MantidQt/CustomInterfaces/src/Indirect/CalcCorr.cpp Code/Mantid/MantidQt/CustomInterfaces/src/Indirect/ConvFit.cpp Code/Mantid/MantidQt/CustomInterfaces/src/Indirect/Fury.cpp Code/Mantid/MantidQt/CustomInterfaces/src/Indirect/FuryFit.cpp Code/Mantid/MantidQt/CustomInterfaces/src/Indirect/IndirectCalibration.cpp Code/Mantid/MantidQt/CustomInterfaces/src/Indirect/IndirectDiagnostics.cpp Code/Mantid/MantidQt/CustomInterfaces/src/Indirect/IndirectMoments.cpp Code/Mantid/MantidQt/CustomInterfaces/src/Indirect/IndirectSymmetrise.cpp Code/Mantid/MantidQt/CustomInterfaces/src/Indirect/IndirectTransmission.cpp Code/Mantid/MantidQt/CustomInterfaces/src/Indirect/MSDFit.cpp Code/Mantid/MantidQt/CustomInterfaces/src/IndirectLoadILL.cpp
Refs #10850
Changeset: 803f3a8e792aef72cf634954e08a1a6816731ff2
comment:11 Changed 6 years ago by Dan Nixon
comment:12 Changed 6 years ago by Dan Nixon
- Status changed from inprogress to verify
- Resolution set to fixed
This is being verified as pull request #11.
comment:13 Changed 6 years ago by Dan Nixon
This is being verified as pull request #178.
comment:14 Changed 6 years ago by Dan Nixon
Correct indentation in IndirectBayes
Refs #10850
Changeset: e3ff96fab0124018f472dd5cde126fea7638f656
comment:15 Changed 6 years ago by Dan Nixon
I want to make sure the system tests pass on Windows before this is merged.
comment:16 Changed 6 years ago by Dan Nixon
Jenkins, retest this please.
comment:17 Changed 6 years ago by Martyn Gigg
- Status changed from verify to verifying
- Tester set to Martyn Gigg
comment:18 Changed 6 years ago by Martyn Gigg
The system tests are falling over on the tests in ISISIndirectAbsCorTest and ISISIndirectBayesTest - http://builds.mantidproject.org/job/develop_systemtests_all/label=win7/lastCompletedBuild/. I assume they just need the verbose option removing too?
comment:19 Changed 6 years ago by Dan Nixon
Remove remaining verbose options in indirect tests
Refs #10850
Changeset: 8f657b70d1c6fc691e12e1e67f173534e33063e5
comment:20 Changed 6 years ago by Dan Nixon
I was sure I had gotten all the tests, but yes they still needed the verbose option taken out.
comment:21 Changed 6 years ago by Martyn Gigg
Thanks. I'll double check it again with the servers
comment:22 Changed 6 years ago by Martyn Gigg
Jenkins, retest this please.
comment:23 Changed 6 years ago by Martyn Gigg
@DanNixon Is this ready to go, assuming the builds pass? The develop system tests look okay for indirect but we still have the InProgress label here.
comment:24 Changed 6 years ago by Martyn Gigg
Jenkins, retest this please.
comment:25 Changed 6 years ago by Martyn Gigg
All is well with the builds now.
comment:26 Changed 6 years ago by Dan Nixon
Yeah, the InProgress label is no longer needed. I just added it to prevent it from being merged before the Windows tests had been run.
comment:27 Changed 6 years ago by Martyn Gigg
- Status changed from verifying to closed
Merge pull request #178 from mantidproject/feature/10850_remove_indirect_verbose_option
Remove indirect verbose option
Full changeset: 345ad483aa49afd332304ae804e548d4258885c5
comment:28 Changed 6 years ago by Martyn Gigg
Merge pull request #11 from mantidproject/feature/10850_remove_indirect_verbose_option
Remove indirect verbose option
Full changeset: 301977923fed8fe58570b665d34e24e3e05af850
comment:29 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 11692