Ticket #10880 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

QuickNXS: Use Stitch1D algorithm to find scaling factor

Reported by: Harry Jeffery Owned by: Harry Jeffery
Priority: major Milestone: Release 3.4
Component: Reflectometry Keywords:
Cc: Blocked By:
Blocking: Tester: Federico M Pouzols

Description

This ticket concerns work relating to this repository: ​https://github.com/aglavic/quicknxs

When stitching two workspaces, the scaling factor used should be calculated using the Stitch1D algorithm.

Change History

comment:1 Changed 6 years ago by Harry Jeffery

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Harry Jeffery

  • Status changed from assigned to inprogress

comment:3 Changed 6 years ago by Harry Jeffery

A pull request has been created to fulfil this ticket: ​https://github.com/aglavic/quicknxs/pull/1

comment:4 Changed 6 years ago by Harry Jeffery

  • Status changed from inprogress to verify
  • Resolution set to fixed

Testing

Verify the pull request has been merged.

comment:5 Changed 6 years ago by Federico M Pouzols

  • Status changed from verify to verifying
  • Tester set to Federico M Pouzols

comment:6 Changed 6 years ago by Federico M Pouzols

  • Status changed from verifying to closed

comment:7 Changed 6 years ago by Federico M Pouzols

No code changes required here. Changes were merged in quicknxs a few days ago.

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11719

Note: See TracTickets for help on using tickets.