Ticket #10899 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Bug report: wrong character case in FindOpenCascade.cmake

Reported by: Nick Draper Owned by: Nick Draper
Priority: major Milestone: Release 3.4
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Federico M Pouzols

Description

Name: Joachim Wuttke Email: j.wuttke@…

In file Code/Mantid/Build/CMake/FindOpenCascade.cmake, line 63, "OPENCASCADE_LIB_TKGEOMAlgo" should be all uppercase, as in lines 78 and 92. Unless this is repaired, the availability of libTKGeomAlgo.so is not checked.

Change History

comment:1 Changed 6 years ago by Nick Draper

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Nick Draper

  • Status changed from assigned to inprogress

re #10899 Fixing a casing error in FindOpenCasade.cmake

Changeset: fe3e9486183dc96ae2afc5a8befa5c1219d664dd

comment:3 Changed 6 years ago by Nick Draper

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:4 Changed 6 years ago by Federico M Pouzols

  • Status changed from verify to verifying
  • Tester set to Federico M Pouzols

comment:5 Changed 6 years ago by Federico M Pouzols

I cannot test this one cause the branch is not merged into develop. It seems that it needs a 'checkbuild'. Could you have a look?

comment:6 Changed 6 years ago by Federico M Pouzols

  • Status changed from verifying to reopened
  • Resolution fixed deleted

Gently reopening the ticket as a gentle reminder after the many meetings.

It definitely works. I guess we need a pull request for this branch?

comment:7 Changed 6 years ago by Nick Draper

  • Status changed from reopened to verify
  • Resolution set to fixed

pull request ​https://github.com/mantidproject/mantid/pull/263

comment:8 Changed 6 years ago by Federico M Pouzols

  • Status changed from verify to verifying

comment:9 Changed 6 years ago by Martyn Gigg

Could you update the pull request title to remove the ticket number, following the guidelines [here](http://www.mantidproject.org/Git_Workflow).

comment:10 Changed 6 years ago by Federico M Pouzols

  • Status changed from verifying to closed

Merge pull request #263 from mantidproject/feature/10899_findOpenCascadeError

Fixing a casing error in FindOpenCasade.cmake

Full changeset: ​aa6729c290f37379e34d84d5242bef0ab3e759a0

comment:11 Changed 5 years ago by Nick Draper

Somehow these slipped through without a resolution. Set to Fixed.

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11738

Note: See TracTickets for help on using tickets.