Ticket #10907 (assigned)

Opened 6 years ago

Last modified 5 years ago

EnginXFitPeaks expected Peak analysis problem

Reported by: Lottie Greenwood Owned by: Federico M Pouzols
Priority: major Milestone: Release 3.5
Component: Diffraction Keywords:
Cc: Blocked By:
Blocking: #8368 Tester:

Description

When entering a list of expectedPeaks into FitPeaks, if one expected peak is not there, the algorithm will stop and not produce any results. If just one peak is out of range of the data then this should be stated but otherwise ignored. If all expectedPeaks are not there then the algorithm should fail gracefully.

This affects EnginXCalibrate and CalibrateFull which both utilise FitPeaks.

Change History

comment:1 Changed 6 years ago by Lottie Greenwood

  • Status changed from new to assigned

comment:2 Changed 5 years ago by Nick Draper

  • Milestone changed from Release 3.4 to Release 3.5

Moved to R3.5 at the R3.4 code freeze

comment:3 Changed 5 years ago by Lottie Greenwood

  • Owner changed from Lottie Greenwood to Federico M Pouzols

comment:4 Changed 5 years ago by Federico M Pouzols

  • Blocking 8368 added

(In #8368) Added new ENGIN-X tickets that have been opened in the last few months as 'blocked by'.

comment:5 Changed 5 years ago by Federico M Pouzols

Note that in addition to

  • sometimes FindPeaks will not find the expected peaks

The following can happen:

  • FindPeaks finds them, but it produces 0 width and/or height

This is currently skipped with an if... continue when processing the workspace spectra.

comment:6 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11746

Note: See TracTickets for help on using tickets.