Ticket #10921 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

EnginX Algorithms unit tests

Reported by: Lottie Greenwood Owned by: Federico M Pouzols
Priority: major Milestone: Release 3.5
Component: Diffraction Keywords:
Cc: Blocked By:
Blocking: #8368 Tester: Anders-Markvardsen

Description (last modified by Federico M Pouzols) (diff)

The python scripts for the EnginX algorithms currently have no unit tests. Write them for EnginXFocus,FitPeaks, Calibrate and CalibrateFull.

Change History

comment:1 Changed 6 years ago by Lottie Greenwood

  • Status changed from new to assigned

comment:2 Changed 5 years ago by Nick Draper

  • Milestone changed from Release 3.4 to Release 3.5

Moved to R3.5 at the R3.4 code freeze

comment:3 Changed 5 years ago by Lottie Greenwood

  • Owner changed from Lottie Greenwood to Federico M Pouzols

comment:4 Changed 5 years ago by Federico M Pouzols

  • Blocking 8368 added

(In #8368) Added new ENGIN-X tickets that have been opened in the last few months as 'blocked by'.

comment:5 Changed 5 years ago by Federico M Pouzols

  • Description modified (diff)

There seem to be no unit tests at all for EnginX* algorithms.

There's one system test: EnginXCalibrate. Maybe additional or an extended system test could be added as well (I'd keep that as a separate ticket).

comment:6 Changed 5 years ago by Federico M Pouzols

  • Summary changed from EnginX Algorithm unit tests to EnginX Algorithms unit tests

comment:7 Changed 5 years ago by Federico M Pouzols

Note that there are simple doc-tests for the 4 algorithms already in place.

comment:8 Changed 5 years ago by Federico Montesino Pouzols

  • Status changed from assigned to inprogress

fix typo in MDgeometry error message, re #10921

Changeset: 82e26f1e3e3b558571c6634eab02c5cb8c3c4e32

comment:9 Changed 5 years ago by Federico Montesino Pouzols

add test files and tests for EnginXFocus, re #10921

Changeset: a0bd0ff84ad99f8546edca3d2dc338f68240a975

comment:10 Changed 5 years ago by Federico Montesino Pouzols

add unit tests for all enginx algorithms, re #10921

Changeset: 993f9afc0999a4cd2a932b55aed834d35f035ead

comment:11 Changed 5 years ago by Federico Montesino Pouzols

add small enginx file for unit tests, re #10921

Changeset: 29dbee68286c9e0e1c4fe68f17dcfd66b24386b4

comment:12 Changed 5 years ago by Federico Montesino Pouzols

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #787.

comment:13 Changed 5 years ago by Federico Montesino Pouzols

I'll have to change to a very approx comparison in some asserts. Fitting results are different from the 4rth digit on OSX.

comment:14 Changed 5 years ago by Federico Montesino Pouzols

use approx comparisons for osx fitting, re #10921

Changeset: 87549b65fb5f3afe7392c28f7c4a8f977ec8f7a2

comment:15 Changed 5 years ago by Federico Montesino Pouzols

relax assert comparisons for different platforms, re #10921

Changeset: fab23a3d638f4bc194725e9d4b6e58083a7f8950

comment:16 Changed 5 years ago by Federico Montesino Pouzols

assertLess too modern, and more tolerant error thresholds, re #10921

Changeset: 89814f46e7aa38db03f032568c5442065935b518

comment:17 Changed 5 years ago by Anders-Markvardsen

  • Status changed from verify to closed
  • Tester set to Anders-Markvardsen

Merge pull request #787 from mantidproject/10921_unit_tests_enginx_algs

Add unit tests for ENGINX algorithms

Full changeset: ​4f51e30a8ec184f6bd6c9e2fe191c48d48bcfcca

comment:18 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11760

Note: See TracTickets for help on using tickets.