Ticket #10924 (assigned)

Opened 6 years ago

Last modified 5 years ago

QuickNXS: Resolve hardcoded instrument values

Reported by: Harry Jeffery Owned by: Jean Bilheux
Priority: critical Milestone: Release 3.5
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester:

Description

​https://github.com/aglavic/quicknxs/pull/5 introduces many comments annotating areas of the QuickNXS code that are troublesome for ISIS. These hardcoded values and strings need to be resolved before ISIS can begin to use QuickNXS.

There are three comments introduced:

  • TODO MAGIC NUMBER - Highlights a hardcoded numbers
  • TODO HARDCODED STRING - Highlights hardcoded strings
  • TODO HARDCODED INSTRUMENT - Highlights hardcoded dependencies on an instrument

They should be easily findable using git grep. The goal of this ticket is to review each highlighted area and resolve it, until all of the TODO comments have been removed.

Change History

comment:1 Changed 6 years ago by Nick Draper

  • Status changed from new to assigned

comment:2 Changed 5 years ago by Nick Draper

  • Milestone changed from Release 3.4 to Release 3.5

Moved to R3.5 at the end of R3.4

comment:3 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11763

Note: See TracTickets for help on using tickets.