Ticket #10928 (closed: fixed)
Create instrument definition file for HB2A
Reported by: | Wenduo Zhou | Owned by: | Wenduo Zhou |
---|---|---|---|
Priority: | major | Milestone: | Release 3.4 |
Component: | Framework | Keywords: | |
Cc: | petersonpf@… | Blocked By: | |
Blocking: | #10622 | Tester: | Ricardo Leal |
Description
Create the IDF file for HB2A.
And add an instrument generation python script to the mantidgeometry repository.
Attachments
Change History
comment:2 Changed 6 years ago by Wenduo Zhou
Added HB2A IDF file. Refs #10928.
On branch feature/10928_hb2a_idf
new file: HB2A_Definition.xml
Changeset: 927e8aedb852d0716aff65093dac48f1b01365e7
comment:3 Changed 6 years ago by Wenduo Zhou
Replaced with IDF generated from hb2a_geometry.py. Refs #10928.
Changeset: 89f2569e18c8c7786d193da6905a0aa2f417d7ad
Changed 6 years ago by Wenduo Zhou
- Attachment verify10928.py added
script to help to verify the ticket
Changed 6 years ago by Wenduo Zhou
- Attachment HB2A_Definition_manual.xml added
HB2A's IDF made manually
comment:4 Changed 6 years ago by Wenduo Zhou
For tester
- I added the IDF for HFIR's HB2A. Tester can create an arbitrary MatrixWorkspace, and do LoadInstrument with the instrument name as 'HB2A'. You should be able to launch the instrument view from the workspace then.
- In order to check whether it is correct or not, you can download the verification script and an IDF made manually. Run the script to see whether the manually generated IDF can always have the same instrument with the one in Mantid.
Be noticed that HB2A's instrument will look for a sample log named 'rotangle' to determine the first detector's position (2theta). You can vary the value of rotangle to see its impact on the instrument generated.
- A script to generate HB2A's IDF is added to mantidgeometry. The HB2A's IDF added to Mantid is generated by this script. You may run test_unchanged.py because helper.py was modified slightly.
comment:6 Changed 6 years ago by Wenduo Zhou
- Status changed from assigned to verify
- Resolution set to fixed
comment:7 Changed 6 years ago by Ricardo Leal
- Status changed from verify to verifying
- Tester set to Ricardo Leal
comment:8 Changed 6 years ago by Ricardo M. Ferraz Leal
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/10928_hb2a_idf'
Full changeset: 665d2712eb2c64e4404b4413396068c429eef339
comment:9 Changed 5 years ago by Nick Draper
Somehow these slipped through without a resolution. Set to Fixed.
comment:10 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 11767