Ticket #1093 (closed: fixed)

Opened 11 years ago

Last modified 5 years ago

Rebin not thread-safe when there are masked bins

Reported by: Russell Taylor Owned by: Russell Taylor
Priority: critical Milestone: Iteration 21
Component: Keywords:
Cc: Blocked By:
Blocking: Tester:

Description

When running the SANSAnalysis system test I don't always get the same answer. Sometimes I even get a crash. This only seems to happen if there are masked bins present and goes away if I disable multi-threading on the Rebin algorithm (which I'm about to do).

Change History

comment:1 Changed 11 years ago by Russell Taylor

(In [3726]) Temporarily disable multithreading in Rebin until we understand why it messes up the result when there are masked bins. Re #1093.

comment:2 Changed 11 years ago by Russell Taylor

  • Status changed from new to accepted
  • Owner set to Russell Taylor

comment:3 Changed 11 years ago by Russell Taylor

(In [3734]) Put critical region protection in MatrixWorkspace::maskBin because it's not thread-safe. Despite this, took the masking propagation out of the parallel loop in SimpleRebin to be more efficient. Re #1093.

comment:4 Changed 11 years ago by Russell Taylor

  • Status changed from accepted to testing
  • Resolution set to fixed

comment:5 Changed 11 years ago by Martyn Gigg

  • Status changed from testing to closed

comment:6 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​1941

Note: See TracTickets for help on using tickets.