Ticket #10931 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Fix coverity issues in instrument view pick tab

Reported by: Roman Tolchenov Owned by: Roman Tolchenov
Priority: major Milestone: Release 3.4
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Harry Jeffery

Description

CID 1265573: Division or modulo by zero (DIVIDE_BY_ZERO) InstrumentWindowPickTab.cpp: 1474 in DetectorPlotController::savePlotToWorkspace()()

CID 1265572: Uninitialized scalar field (UNINIT_CTOR) /home/builder/jenkins-InstrumentWindowPickTab.cpp: 924 in DetectorPlotController::DetectorPlotController(InstrumentWindowPickTab *, InstrumentActor *, OneCurvePlot *)()

CID 1265571: Uninitialized pointer field (UNINIT_CTOR) InstrumentWindowPickTab.cpp: 240 in InstrumentWindowPickTab::InstrumentWindowPickTab(InstrumentWindow *)()

CID 1265570: Structurally dead code (UNREACHABLE) InstrumentWindowPickTab.cpp: 1534 in DetectorPlotController::getTubeXUnitsName() const()

Change History

comment:1 Changed 6 years ago by Roman Tolchenov

Re #10931. Fixing the issues.

Changeset: 58eefd02d98697af50e95798bb0bbddaa0d4db57

comment:2 Changed 6 years ago by Roman Tolchenov

  • Status changed from new to assigned

comment:3 Changed 6 years ago by Roman Tolchenov

  • Status changed from assigned to verify
  • Resolution set to fixed

comment:4 Changed 6 years ago by Harry Jeffery

  • Status changed from verify to verifying
  • Tester set to Harry Jeffery

comment:5 Changed 6 years ago by Harry Jeffery

I checked each Coverity issue mentioned, and they've been addressed to my satisfaction.

comment:6 Changed 6 years ago by Harry Jeffery

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/10931_pick_tab_coverity_issues'

Full changeset: ​afab71132751cd6bf0bf3ce42e1eb87c87972eeb

comment:7 Changed 5 years ago by Nick Draper

Somehow these slipped through without a resolution. Set to Fixed.

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11770

Note: See TracTickets for help on using tickets.