Ticket #10957 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Goniometer rotation sense is not used

Reported by: Andrei Savici Owned by: Andrei Savici
Priority: critical Milestone: Release 3.4
Component: Framework Keywords: patch candidate
Cc: rwp@… Blocked By:
Blocking: Tester: Harry Jeffery

Description

The goniometer axis has an option for clockwise or counter-clockwise rotation. Unfortunately, one gets the same rotation matrix. To test: 

w=Load('CNCS_7860')
SetGoniometer(w,Axis0="10,0,1,0,1")
print w.run().getGoniometer().getR()
SetGoniometer(w,Axis0="10,0,1,0,-1")
print w.run().getGoniometer().getR()
SetGoniometer(w,Axis0="10,0,-1,0,1")
print w.run().getGoniometer().getR()

The last two matrices have to be the same. Currently the first two are the same

Change History

comment:1 Changed 6 years ago by Andrei Savici

  • Cc rwp@… added

comment:2 Changed 6 years ago by Andrei Savici

Fix goniometer sense. Refs #10957

Changeset: 34e5c1cda6447b44a36a5e47d1056e6f12f1af80

comment:3 Changed 6 years ago by Andrei Savici

Minor documentation typo. Refs #10957

Changeset: 6c3dfce1f647c3b7b4392af0e05e32f300b27103

comment:4 Changed 6 years ago by Andrei Savici

  • Status changed from new to assigned

comment:5 Changed 6 years ago by Andrei Savici

  • Status changed from assigned to verify
  • Resolution set to fixed

comment:6 Changed 6 years ago by Harry Jeffery

  • Status changed from verify to verifying
  • Tester set to Harry Jeffery

comment:7 Changed 6 years ago by Harry Jeffery

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/10957_goniometersense'

Full changeset: ​f8e44286fc2c3aafd4d0c27b1b071236ae22a268

comment:8 Changed 5 years ago by Nick Draper

Somehow these slipped through without a resolution. Set to Fixed.

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11796

Note: See TracTickets for help on using tickets.