Ticket #10959 (closed: fixed)
BugFix: SliceAlgorithmDialog sends incorrect dimension information
Reported by: | Anton Piccardo-Selg | Owned by: | Anton Piccardo-Selg |
---|---|---|---|
Priority: | major | Milestone: | Release 3.4 |
Component: | GUI | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Roman Tolchenov |
Description
To reproduce:
- Load two event MD event workspaces into MantidPlot of which one has three dimensions and the other has four dimensions.
- Execute the BinMD algorithm. The BinMD algorithm dialog will appear.
- Load the four-dim workspace and bin it.
- Execute the BinMD algorithm. The BinMD algorithm dialog will appear.
- Load the three-dim workspace and bin it.
- You shoud see an error message.
The dialog memorises the strucutre of the workspace which was loaded last. When you load the four-dim workspace it creates a dimension property which is four-dim. Then when we switch to a three-dim workspace the last dimsion structure is not flushed from the dimension property
Attachments
Change History
comment:2 Changed 6 years ago by Anton Piccardo-Selg
Refs #10959 Moving slice algorithm dialog to MantidWidgets
Changeset: 179be9b43fb92f29da7e41add2f96c3d7db00b47
comment:3 Changed 6 years ago by Anton Piccardo-Selg
For testing:
You need two workspaces for testing: MDEvent1 which is 4D and MDEvent2 which is 3D. I could attach only MDEvent1 due to the size limit. Please ask me for the other workspace which I will email to you.
Essentially we want to make sure that there are no error messages or warnings when we perform BinMD and that the output workspaces are being produced.
- Load both workspaces
- Open the BinMD dialog (search for it in the algorithm search bar), select MDEvent1 as the input workspace and name the output workspace "out1"
- Perform the binning.
- Confirm that there are no error messages in the "Results log"
- Confirm that the workspace "out1" has the correct dimensional information (i.e. the bins are what you had set them to)
- Open the BinMD dialog, select MDEvent2 as the input workspace and name the output workspace "out2"
- Perform the binning.
- Confirm that there are no error messages in the "Results log". Note, that the error was at this point.
- Confirm that the workspace "out2" has the correct dimensional information (i.e. the bins are what you had set them to)
Please code review this
comment:6 Changed 6 years ago by Anton Piccardo-Selg
- Status changed from inprogress to verify
- Resolution set to fixed
comment:8 Changed 6 years ago by Roman Tolchenov
- Status changed from verify to verifying
- Tester set to Roman Tolchenov
comment:9 Changed 6 years ago by Roman Tolchenov
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/bugfix/10959_fix_slice_algorithm_dialog_dimension_issue'
Full changeset: 3a70f9fc3d18e8e485ecba302f6ceb8ceb2db8d1
comment:10 Changed 6 years ago by Roman Tolchenov
Merge remote-tracking branch 'origin/bugfix/10959_fix_slice_algorithm_dialog_dimension_issue'
Full changeset: 3a70f9fc3d18e8e485ecba302f6ceb8ceb2db8d1
comment:11 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 11798
Refs #10959 Fix the slice algorithm dialog dimension issue
Changeset: 06356e112acd08f30c8f38207a6aa2d54a05dd93