Ticket #10959 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

BugFix: SliceAlgorithmDialog sends incorrect dimension information

Reported by: Anton Piccardo-Selg Owned by: Anton Piccardo-Selg
Priority: major Milestone: Release 3.4
Component: GUI Keywords:
Cc: Blocked By:
Blocking: Tester: Roman Tolchenov

Description

To reproduce:

  1. Load two event MD event workspaces into MantidPlot of which one has three dimensions and the other has four dimensions.
  2. Execute the BinMD algorithm. The BinMD algorithm dialog will appear.
  3. Load the four-dim workspace and bin it.
  4. Execute the BinMD algorithm. The BinMD algorithm dialog will appear.
  5. Load the three-dim workspace and bin it.
  6. You shoud see an error message.

The dialog memorises the strucutre of the workspace which was loaded last. When you load the four-dim workspace it creates a dimension property which is four-dim. Then when we switch to a three-dim workspace the last dimsion structure is not flushed from the dimension property

Attachments

MDEvent1.nxs (2.3 MB) - added by Anton Piccardo-Selg 6 years ago.

Change History

comment:1 Changed 6 years ago by Anton Piccardo-Selg

Refs #10959 Fix the slice algorithm dialog dimension issue

Changeset: 06356e112acd08f30c8f38207a6aa2d54a05dd93

comment:2 Changed 6 years ago by Anton Piccardo-Selg

Refs #10959 Moving slice algorithm dialog to MantidWidgets

Changeset: 179be9b43fb92f29da7e41add2f96c3d7db00b47

comment:3 Changed 6 years ago by Anton Piccardo-Selg

For testing:

You need two workspaces for testing: MDEvent1 which is 4D and MDEvent2 which is 3D. I could attach only MDEvent1 due to the size limit. Please ask me for the other workspace which I will email to you.

Essentially we want to make sure that there are no error messages or warnings when we perform BinMD and that the output workspaces are being produced.

  1. Load both workspaces
  2. Open the BinMD dialog (search for it in the algorithm search bar), select MDEvent1 as the input workspace and name the output workspace "out1"
  3. Perform the binning.
  4. Confirm that there are no error messages in the "Results log"
  5. Confirm that the workspace "out1" has the correct dimensional information (i.e. the bins are what you had set them to)
  6. Open the BinMD dialog, select MDEvent2 as the input workspace and name the output workspace "out2"
  7. Perform the binning.
  8. Confirm that there are no error messages in the "Results log". Note, that the error was at this point.
  9. Confirm that the workspace "out2" has the correct dimensional information (i.e. the bins are what you had set them to)

Please code review this

Changed 6 years ago by Anton Piccardo-Selg

comment:4 Changed 6 years ago by Anton Piccardo-Selg

  • Status changed from new to assigned

comment:5 Changed 6 years ago by Anton Piccardo-Selg

  • Status changed from assigned to inprogress

comment:6 Changed 6 years ago by Anton Piccardo-Selg

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:7 Changed 6 years ago by Anton Piccardo-Selg

Please see comment: 3 for test instructions

comment:8 Changed 6 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:9 Changed 6 years ago by Roman Tolchenov

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/10959_fix_slice_algorithm_dialog_dimension_issue'

Full changeset: 3a70f9fc3d18e8e485ecba302f6ceb8ceb2db8d1

comment:10 Changed 6 years ago by Roman Tolchenov

Merge remote-tracking branch 'origin/bugfix/10959_fix_slice_algorithm_dialog_dimension_issue'

Full changeset: 3a70f9fc3d18e8e485ecba302f6ceb8ceb2db8d1

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 11798

Note: See TracTickets for help on using tickets.