Ticket #10970 (closed: fixed)
Add MonitorsAsEvents in LoadEventNexusTest
Reported by: | Federico M Pouzols | Owned by: | Federico M Pouzols |
---|---|---|---|
Priority: | major | Milestone: | Release 3.4 |
Component: | Framework | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | #10619 | Tester: | Vickie Lynch |
Description
This functionality seems very fragile, in the middle of a somewhat messy code, but seems important and can make some system tests fail. So the 'MonitorsAsEvents' property should be tested in combination with 'LoadMonitors' in the LoadEventNexus unit test.
All other input properties seem tested, except maybe SpectrumMin and SpectrumMax (SpectrumList is).
Bonus: add also a simple test for min/max (can easily go into the current test case test_partial_spectra_loading().
Change History
comment:4 Changed 6 years ago by Federico Montesino Pouzols
Add test for MonitorsAsEvent option, also spec min/max/list re #10970
Changeset: e34e33f1e1193e9abff8657213a3645ff5448930
comment:5 Changed 6 years ago by Federico M Pouzols
- Status changed from inprogress to verify
- Resolution set to fixed
This just adds additional checks to the test. There's a new test case for 'MonitorsAsEvents' and the test_partial_spectra_loading() has also been extended to check min/max/list of spectra. This should help to catch issues around these LoadEventNexus algorithms as early as possible. To test:
- check that unit tests pass and that the code/checks that have been added make sense.
Note: like with test_Load_And_CompressEvents()+test_Monitors() I've re-used one of the loads for the MonitorsAsEvents test.
comment:6 Changed 6 years ago by Vickie Lynch
- Status changed from verify to verifying
- Tester set to Vickie Lynch
comment:7 Changed 6 years ago by Vickie Lynch
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/10970_add_MonitorsAsEvents_in_LoadEventNexusTest'
Full changeset: c5c93525c14bd81e00ef8341d54199f068e8ffb2
comment:8 Changed 6 years ago by Vickie Lynch
Merge remote-tracking branch 'origin/feature/10970_add_MonitorsAsEvents_in_LoadEventNexusTest'
Full changeset: c5c93525c14bd81e00ef8341d54199f068e8ffb2
comment:9 Changed 5 years ago by Nick Draper
Somehow these slipped through without a resolution. Set to Fixed.
comment:10 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 11809