Ticket #10975 (assigned)

Opened 6 years ago

Last modified 5 years ago

Clarify issues with static methods in LoadEventNexus being used by other algorithms

Reported by: Federico M Pouzols Owned by: Federico M Pouzols
Priority: major Milestone: Release 3.5
Component: Framework Keywords: Maintenance, CORE
Cc: Blocked By:
Blocking: #10619 Tester:

Description

As explained in ​http://trac.mantidproject.org/mantid/ticket/8172#comment:18, the LoadEventNexus algorithm class has several static methods that are used from other algorithms:

  • LoadEventNexus::LoadEntryMetadata: used by LoadTOFRawNexus, LoadNexusMonitors
  • LoadEventNexus::runLoadIDFFromNexus: used by LoadISISNexus2
  • LoadEventNexus::runLoadInstrument: used by LoadTOFRawNexus, LoadPreNexus
  • LoadEventNexus::runLoadNexusLogs: used by LoadTOFRawNexus

To re-use the already open NeXus file instead of re-opening it several times, these algorithms would need to be updated at once, so this was left out of ticket #8172.

In principle it should be possible to pass the (static) methods listed above a reference or pointer to the NeXus::File objects instead of/in addition to the file name.

Also, this use of static methods looks a bit suspicious and calling for maintenance trouble. Clarify and/or fix this issue.

Change History

comment:1 Changed 6 years ago by Federico M Pouzols

  • Blocking 10619 added

comment:2 Changed 6 years ago by Federico M Pouzols

  • Status changed from new to assigned

comment:3 Changed 6 years ago by Federico M Pouzols

  • Keywords Maintenance, CORE added; Maintenance removed

Added CORE keyword as suggested by Anders.

comment:4 Changed 5 years ago by Nick Draper

  • Milestone changed from Release 3.4 to Release 3.5

Moved to R3.5 at the R3.4 code freeze

comment:5 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11814

Note: See TracTickets for help on using tickets.