Ticket #10980 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Load ISIS Nexus does not load correct monitor information if monitors are loaded separately form workspace

Reported by: Alex Buts Owned by: Alex Buts
Priority: critical Milestone: Release 3.4
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Dan Nixon

Description (last modified by Alex Buts) (diff)

Try to load MAPS workspace (tried on the run MAP21384.nxs) which can be found on data service or ftp at: ​ftp://ftp.nd.rl.ac.uk/scratch/abuts/Ticket_10980/

and select monitors-include. Look at detector table -- it has correct monitors with correct monitors positions.

Try to load monitors separately -- Monitors workspace do not have spectra ID, detectors ID and spectra are not marked as monitors.

Fixing this ticket should also involve fixing system test:

ISISDirectReductionComponents, (row 189, reference to this ticket) and verifying it passes. The reason it fails is this bug.

Change History

comment:1 Changed 6 years ago by Alex Buts

  • Description modified (diff)

comment:2 Changed 6 years ago by Alex Buts

  • Description modified (diff)

comment:3 Changed 6 years ago by Alex Buts

  • Owner set to Alex Buts
  • Status changed from new to assigned

comment:4 Changed 6 years ago by Alex Buts

  • Status changed from assigned to inprogress

Re #10980 This should fix it, though unit test for this case

still needed

Changeset: 663d95b6962ce5a6ec0f101378d3ca3b795dfd22

comment:5 Changed 6 years ago by Alex Buts

Re #10980 Enabled MERLIN system test for separate monitor loading

which would fail earlier

Changeset: 050247c3fdc015d147d0e5c2ca1fd1d925a73eba

comment:6 Changed 6 years ago by Alex Buts

Easy to test ticket -- just load ISIS histogram nexus with monitors separate (e.g. one from unit tests or system tests mentioned in commits) with Mantid before and after the fix and look at the detectors for monitor workspace.

Current Mantid provides empty table and fix gives us proper detector table with correct spectra to detector map

comment:7 Changed 6 years ago by Alex Buts

Re #10980 Unit test to verify the algorithms logic

Changeset: 52300432b79b616edefd09c121020827959e984c

comment:9 Changed 6 years ago by Alex Buts

Re #10980 Disabled unit test as file used there is not available

for unit tests

Changeset: f03161c7f33502762e932f2e2659c342d64641fb

comment:10 Changed 6 years ago by Alex Buts

You also may try to enable and verify unit test I've tested on windows and disabled as file, used in the test (though I am reading only small part of this file) is used in system tests and not avail for unit tests.

Despite it would be nice to have it as a unit test too, the system test remains and adequately verifies the work of the fixed algorithm.

comment:11 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verifying
  • Tester set to Dan Nixon

comment:12 Changed 6 years ago by Dan Nixon

  • Status changed from verifying to closed

Merge pull request #483 from mantidproject/10980_LoadISISNexusMonitors

bug in load isis nexus monitors

Full changeset: ​1ffd2722641a7d2fc2f4bfbb380443ab196388b6

comment:13 Changed 5 years ago by Nick Draper

  • Resolution set to fixed

Somehow these slipped through without a resolution. Set to Fixed.

comment:14 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11819

Note: See TracTickets for help on using tickets.