Ticket #11004 (closed: fixed)
Use all runs in FindPeaksMD
Reported by: | Vickie Lynch | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | Release 3.4 |
Component: | Framework | Keywords: | |
Cc: | yef1@…, saviciat@… | Blocked By: | |
Blocking: | #11056 | Tester: | Ross Whitfield |
Description
From SNS user: After I merge md workspace using the following command, I obtained the mdqsamp.
mdqsamp=MergeMD(mdqsampparts)
If I use FindpeaksMD to get peaks, only the first run of all merged runs is used to find peak. Is it a bug in the algorithm? Ideally we should get peaks from all runs.
Line from FindPeaksMD that should loop over runs:
ExperimentInfo_sptr ei = ws->getExperimentInfo(0);
Change History
comment:2 Changed 6 years ago by Andrei Savici
This approach will fail to record peaks for which it cannot find a detector with the first goniometer settings.
comment:3 Changed 6 years ago by Vickie Lynch
Refs #11004 find peaks from all runs that can be mapped to a detector
Changeset: 150a8635b8f624951cca6295c719004a28aa0672
comment:4 Changed 6 years ago by anonymous
- Status changed from new to verify
- Resolution set to fixed
This is being verified as pull request #176.
comment:5 Changed 6 years ago by Vickie Lynch
Refs #11004 fix unit test
Changeset: 7846a35649622a242f2f3850b62d3957260812a9
comment:6 Changed 6 years ago by Vickie Lynch
Refs #11004 fix warning in test
Changeset: 49d8f45c3f802625cb3b1f7cffec701dab674f15
comment:7 Changed 6 years ago by anonymous
This is being verified as pull request #183.
comment:8 Changed 6 years ago by anonymous
This is being verified as pull request #192.
comment:9 Changed 6 years ago by Vickie Lynch
Refs #11004 fix windows warning in test
Changeset: 75a35361a4d94971ca52a3bed41ef2ff6424a32f
comment:10 Changed 6 years ago by anonymous
retest this please
comment:11 Changed 6 years ago by Ross Whitfield
- Status changed from verify to verifying
- Tester set to Ross Whitfield
comment:13 Changed 6 years ago by Ross Whitfield
- Status changed from verifying to closed
Merge pull request #192 from mantidproject/11004_FindPeaks_all_runs
11004 find peaks all runs
Full changeset: cd1f59324251bc4817c9e979ec63ff8ccd738602
comment:14 Changed 5 years ago by Nick Draper
Somehow these slipped through without a resolution. Set to Fixed.
comment:15 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 11843
From Andrei: I am just wondering if there are contributions from two workspaces to the same peak, what goniometer setting should we use. I think the algorithm uses the peaks from different workspaces, just converts Q sample to Q lab using the first goniometer.