Ticket #11023 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Operator != of Kernel::Matrix is wrong

Reported by: Michael Wedel Owned by: Michael Wedel
Priority: major Milestone: Release 3.4
Component: Framework Keywords:
Cc: Blocked By:
Blocking: #10305 Tester: Harry Jeffery

Description

While working on #10305 I discovered that Kernel::Matrix::operator!=() does exactly the opposite of what it's supposed to do. It returns the result of Kernel::Matrix::equal(), while it should return the negative of that.

Change History

comment:1 Changed 6 years ago by Michael Wedel

Refs #11023. Added failing unit test for Kernel::Matrix

Changeset: 86ba462ccfcde01882d13447ffa5b7faa11ee031

comment:2 Changed 6 years ago by Michael Wedel

Refs #11023. Fix inequality operator.

With this change, the previously failing test passes.

Changeset: 07c6e4f7f900127a94368059ea3605c28f5e02f7

comment:3 Changed 6 years ago by Michael Wedel

  • Status changed from new to verify
  • Resolution set to fixed

This is being verified as pull request #174.

comment:4 Changed 6 years ago by Michael Wedel

Testing information Not much to test, only code review.

comment:5 Changed 6 years ago by Harry Jeffery

  • Status changed from verify to verifying
  • Tester set to Harry Jeffery

comment:6 Changed 6 years ago by Harry Jeffery

  • Status changed from verifying to closed

Merge pull request #174 from mantidproject/11023_fix_inequality_operator_of_matrix

11023 fix inequality operator of matrix

Full changeset: b275b7e9fd0fb65b2c73b67840006c61d0740d3d

comment:7 Changed 6 years ago by Harry Jeffery

Merge pull request #174 from mantidproject/11023_fix_inequality_operator_of_matrix

11023 fix inequality operator of matrix

Full changeset: b275b7e9fd0fb65b2c73b67840006c61d0740d3d

comment:8 Changed 5 years ago by Nick Draper

Somehow these slipped through without a resolution. Set to Fixed.

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 11862

Note: See TracTickets for help on using tickets.