Ticket #11039 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Fix PoldiSpectrumConstantBackground parameter behavior

Reported by: Michael Wedel Owned by: Michael Wedel
Priority: major Milestone: Release 3.4
Component: Diffraction Keywords: POLDI
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description

In ticket #11035 PoldiSpectrumConstantBackground was modified to wrap FlatBackground instead of inheriting from it. The getParameter method was not implemented, which leads to a failing doctest.

Change History

comment:1 Changed 6 years ago by Michael Wedel

Refs #11039. Fix PoldiSpectrumConstantBackground

Changeset: 7188f8474d086d87b7da9bcaf5e6894392d20964

comment:2 Changed 6 years ago by Michael Wedel

Refs #11039. Apply clang format

Changeset: 85b23c9157a3d4f895c3ea28401aeae42aab4b68

comment:3 Changed 6 years ago by Michael Wedel

  • Status changed from new to verify
  • Resolution set to fixed

This is being verified as ​pull request #191.

comment:4 Changed 6 years ago by Michael Wedel

Testing information Make sure the PoldiAnalyseResiduals doctest passes.

comment:5 Changed 6 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:6 Changed 6 years ago by Martyn Gigg

The documentation tests seem happy now.

comment:7 Changed 6 years ago by Martyn Gigg

  • Status changed from verifying to closed

Merge pull request #191 from mantidproject/11039_fix_failing_poldi_doctest

11039 fix failing poldi doctest

Full changeset: ​a0574354054ad4efb6de3810bea72238466b7663

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11878

Note: See TracTickets for help on using tickets.