Ticket #11069 (closed: fixed)
Refactor ScriptRepository to use InternetHelper
Reported by: | Nick Draper | Owned by: | Nick Draper |
---|---|---|---|
Priority: | major | Milestone: | Release 3.4 |
Component: | Framework | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Dan Nixon |
Description (last modified by Nick Draper) (diff)
The ScriptRepository uses poco net classes directly, move them over to using the InternetHelper class
Change History
comment:1 Changed 6 years ago by Nick Draper
- Description modified (diff)
- Summary changed from Refactor RemoteJobManager to use InternetHelper (cloned) (cloned) to Refactor ScriptRepository to use InternetHelper
comment:3 Changed 6 years ago by Nick Draper
- Status changed from assigned to inprogress
re #11069 ScriptRepo now works with the new internetHelper
Changeset: 1b3e51393e4254907c345e011b034a8d85e147a8
comment:4 Changed 6 years ago by Nick Draper
- Status changed from inprogress to verify
- Resolution set to fixed
comment:5 Changed 6 years ago by Nick Draper
Testing as pull request https://github.com/mantidproject/mantid/pull/238
comment:6 Changed 6 years ago by Nick Draper
re #11069 Merge of master instroduced an error - solved
Changeset: 392a0c9178fe3294a1d034b267149a777e006d64
comment:7 Changed 6 years ago by Dan Nixon
- Status changed from verify to verifying
- Tester set to Dan Nixon
comment:8 Changed 6 years ago by Dan Nixon
Seems that there is a [build warning](http://builds.mantidproject.org/job/pull_requests/570/label=rhel6-build/warnings20Result/source.142/#57) coming from ScriptRepositoryImpl.cpp.
comment:9 Changed 6 years ago by Nick Draper
re #11069 fix warning
Changeset: 7d0c670476ec29709cd94ce3a7d61dbe5f0a8883
comment:10 Changed 6 years ago by Dan Nixon
- Status changed from verifying to closed
Merge pull request #238 from mantidproject/feature/11069_ScriptRepo_to_use_InternetHelper
ScriptRepo now works with the new internetHelper
Full changeset: 2e32c70da403be00814c0355d7140e38143d3944
comment:11 Changed 5 years ago by Nick Draper
Somehow these slipped through without a resolution. Set to Fixed.
comment:12 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 11908