Ticket #11072 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Add a UI for the new sample transmission calculator

Reported by: Dan Nixon Owned by: Dan Nixon
Priority: major Milestone: Release 3.4
Component: GUI Keywords:
Cc: Blocked By: #11015, #11036
Blocking: Tester: Federico M Pouzols

Description (last modified by Dan Nixon) (diff)

A UI should be created for this algorithm, it should be similar to the one in indirect tools but show the statistics of the transmission curve and a preview plot of the curve over the supplied wavelength range.

Change History

comment:1 Changed 6 years ago by Dan Nixon

  • Status changed from new to assigned
Last edited 6 years ago by Dan Nixon (previous) (diff)

comment:2 Changed 6 years ago by Dan Nixon

  • Description modified (diff)

comment:3 Changed 6 years ago by Dan Nixon

  • Status changed from assigned to inprogress

Initial work on UI for CalculateSampleTrenamission algo

Refs #11072

Changeset: 0bb3ef24a7b374ae237eeece07ab549741323f26

comment:4 Changed 6 years ago by Dan Nixon

  • Description modified (diff)

comment:5 Changed 6 years ago by Dan Nixon

Label the spectra in the output WS

Refs #11072

Changeset: b788d915ef4abf4ab694b2f70af12fb82980ba0b

comment:6 Changed 6 years ago by Dan Nixon

Add validation to sample transmission UI

Refs #11072

Changeset: ceb9a8de1b4a99b269e34798e65abb071aac1fc7

comment:7 Changed 6 years ago by Dan Nixon

Add more UI validation and improve sizing

Refs #11072

Changeset: 4adc1e9d5755f75dd4dd0f99a484166c8b05724c

comment:8 Changed 6 years ago by Dan Nixon

Added output as tree widget

Refs #11072

Changeset: 98ffcabc7a82c23f4ee1996450068738dc1bb9b4

comment:9 Changed 6 years ago by Dan Nixon

  • Blocked By 11036 added

Could use this plot widget here.

comment:10 Changed 6 years ago by Dan Nixon

Small fixes to UI nad algorithm, added basic doc page

Refs #11072

Changeset: 1c1f601a9ccc431cfba91538c8bdfed3b0e27b7c

comment:11 Changed 6 years ago by Dan Nixon

Merge branch 'master' into feature/11072_sample_transmission_ui

Refs #11072

Changeset: 3ce33ee0aac2be9fba84cfc1b7a787fef2544aff

comment:12 Changed 6 years ago by Dan Nixon

Added preview plot of transmission curve

Refs #11072

Changeset: 45204c84940708447022355919c5aa1687e65813

comment:13 Changed 6 years ago by Dan Nixon

Properly document sample transmission interface

Refs #11072

Changeset: e59c11071f74a4d522006bda8cb8ea3af40d0c19

comment:14 Changed 6 years ago by Dan Nixon

Tidy up UI, added message boxes for failures

Refs #11072

Changeset: 1f6bb6c8a1525d742f90cfc9351ca37bdc5a21e6

comment:15 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as pull request #226.

comment:16 Changed 6 years ago by Dan Nixon

Fix failing UserInputValidator tests

Forgot to update tests for changes made to the results output

Refs #11072

Changeset: 2f78028cbc86ca177540c2b6b81ccc4e5f387a0e

comment:17 Changed 6 years ago by Dan Nixon

Jenkins, retest this please.

comment:18 Changed 6 years ago by Dan Nixon

Merge branch 'master' into feature/11072_sample_transmission_ui

Conflicts:

Code/Mantid/Framework/PythonInterface/plugins/algorithms/CalculateSampleTransmission.py

Refs #11072

Changeset: f9789b71f80dfd23c4f725484cb64fd736706323

comment:19 Changed 6 years ago by Federico M Pouzols

It seems that there're conflicts again.

comment:20 Changed 6 years ago by Dan Nixon

Merge branch 'master' into feature/11072_sample_transmission_ui

Conflicts:

Code/Mantid/Framework/PythonInterface/plugins/algorithms/CalculateSampleTransmission.py

Refs #11072

Changeset: 2b2b756930925d3b0942f6940cc422fa85768934

comment:21 Changed 6 years ago by Federico M Pouzols

  • Status changed from verify to verifying
  • Tester set to Federico M Pouzols

comment:22 Changed 6 years ago by Federico M Pouzols

All looks good to me. Very usable interface. Maybe you could add the x and y axes' titles, although that is well documented and on the dialog it would take space, and probably people using this don't need to be reminded what the plot shows.

comment:23 Changed 6 years ago by Federico M Pouzols

  • Status changed from verifying to closed

Merge pull request #226 from mantidproject/feature/11072_sample_transmission_ui

General sample transmission UI

Full changeset: cf82777a00a84ca98b50fe4f0f9d8d95ef435f9e

comment:24 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 11911

Note: See TracTickets for help on using tickets.