Ticket #11089 (closed: fixed)
Change in fitting has broken some indirect tests
Reported by: | Martyn Gigg | Owned by: | Dan Nixon |
---|---|---|---|
Priority: | blocker | Milestone: | Release 3.4 |
Component: | Indirect Inelastic | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Martyn Gigg |
Description
#11042 fixed a bug with the setting of NumDeriv but this has affected the results of the FuryAndFuryFitMulti indirect tests.
I assume the correct thing to do is just update the reference results.
Change History
comment:2 Changed 6 years ago by Dan Nixon
- Status changed from assigned to inprogress
Update IRIS and OSIRIS ref results for FuryFit tests
Refs #11089
Changeset: 6e47ce7e4e69b1459dd636ac272b250674480095
comment:3 Changed 6 years ago by Dan Nixon
- Status changed from inprogress to verify
- Resolution set to fixed
This is being verified as pull request #13.
comment:4 Changed 6 years ago by Martyn Gigg
- Status changed from verify to verifying
- Tester set to Martyn Gigg
comment:5 Changed 6 years ago by Martyn Gigg
I've re-run this locally against the current master and it now passes
comment:6 Changed 6 years ago by Martyn Gigg
- Status changed from verifying to closed
Merge pull request #13 from mantidproject/feature/11089_update_inelastic_tests_for_fitting_change
Update IRIS and OSIRIS ref results for FuryFit tests
Full changeset: e994c85964a7632640d270bf0ca2bc63528a083d