Ticket #1109 (closed: fixed)
File/Save Nexus option isn't clear when multiple workspaces exist
Reported by: | Martyn Gigg | Owned by: | Federico M Pouzols |
---|---|---|---|
Priority: | minor | Milestone: | Release 3.3 |
Component: | GUI | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Lottie Greenwood |
Description (last modified by Federico M Pouzols) (diff)
If multiple workspaces exist in MantidPlot but none are selected and the "Save Nexus" option is clicked then the first is automatically saved.
This could cause confusion and would probably be best to ask if there is no selection.
Change History
comment:1 Changed 11 years ago by Nick Draper
- Status changed from new to assigned
- Owner set to Sofia Antony
comment:2 Changed 10 years ago by Nick Draper
- Milestone changed from Iteration 26 to Iteration 27
Bulk move of tickets to iteration 27, if your ticket is essential for Iteration 26 then move it back.
comment:3 Changed 10 years ago by Nick Draper
- Milestone changed from Iteration 27 to Iteration 28
Bulk move of tickets at the end of iteration 27
comment:4 Changed 9 years ago by Nick Draper
- Milestone changed from Iteration 28 to Iteration 29
Bulk move of tickets at the end of iteration 28
comment:5 Changed 9 years ago by Nick Draper
- Owner Sofia Antony deleted
- Status changed from assigned to new
Taken from Sofia Antony's list after she left
comment:6 Changed 9 years ago by Nick Draper
- Milestone changed from Iteration 29 to Iteration 30
"New" tickets moved at the code freeze of iteration 29
comment:7 Changed 9 years ago by Nick Draper
- Status changed from new to assigned
- Owner set to Anyone
- Component set to Mantid
comment:8 Changed 9 years ago by Nick Draper
- Milestone changed from Iteration 30 to Iteration 31
Bulk move of tickets to iteration 31 at the iteration 30 code freeze
comment:9 Changed 9 years ago by Nick Draper
- Milestone changed from Iteration 32 to Iteration 33
Moved to iteration 33 at iteration 32 code freeze
comment:10 Changed 8 years ago by Nick Draper
- Milestone changed from Release 2.1 to Release 2.2
Moved at end of release 2.1
comment:11 Changed 8 years ago by Nick Draper
- Milestone changed from Release 2.2 to Release 2.3
Moved at the end of release 2.2
comment:12 Changed 8 years ago by Nick Draper
- Milestone changed from Release 2.3 to Release 2.4
Moved to milestone 2.4
comment:13 Changed 8 years ago by Nick Draper
- Milestone changed from Release 2.4 to Release 2.5
Moved at the code freeze for release 2.4
comment:14 Changed 7 years ago by Nick Draper
- Milestone changed from Release 2.5 to Release 2.6
comment:17 Changed 7 years ago by Nick Draper
- Milestone changed from Release 2.6 to Backlog
Moved to backlog at the code freeze for R2.6
comment:18 Changed 7 years ago by Nick Draper
- Status changed from new to assigned
bulk move to assigned at the into of the triage step
comment:19 Changed 6 years ago by Federico M Pouzols
- Owner changed from Anyone to Federico M Pouzols
- Description modified (diff)
comment:20 Changed 6 years ago by Federico Montesino Pouzols
- Status changed from assigned to inprogress
added disableSaveNexus to keep File->Save in sync, re #1109
Changeset: 852108c50932aa2e012984b4bec2a393c5b6ef6b
comment:21 Changed 6 years ago by Federico M Pouzols
- Status changed from inprogress to verify
- Component changed from Framework to User Interface
- Resolution set to fixed
- Milestone changed from Backlog to Release 3.3
This is the new behavior after the changes made for this venerable ticket. At first, File->Save->Nexus won't be enabled, until the first workspace selection is made. This is the normal behavior, nothing new here. What has changed is that File->Save->Nexus used to remain enabled forever. Now, once you have a workspace selected, it will be enabled but in sync with the "Save" button found at the top of the workspaces windows. When you de-select (get an empty selection by clicking on blank space or removing what you had selected), the button is disabled, and File->Save->Nexus is disabled too. I think that this solution resolves the confusion/ambiguity.
There would be two alternatives:
- as proposed in the ticket description, show a small dialog to ask the user. This could be done using the WorkspaceSelector Mantid widget.
- disable File->Save->"Nexus" in sync with the "Save" button of the workspaces window. So if you have no selection, you cannot save anything and there's no ambiguity
I opted for the 2nd option, as it makes them (main menu File->Save->Nexus and buttons of the workspace window) behave consistently.
To test:
- Load your favorite workspace(s), select and deselect and see that File->Save->Nexus is enabled or disabled depending on whether you have a workspace selected or not (and always in sync with the "Save" button of the workspaces dock window).
There are no unit tests for this but in case I checked all tests pass.
comment:22 Changed 6 years ago by Lottie Greenwood
- Status changed from verify to verifying
- Tester set to Lottie Greenwood
comment:24 Changed 6 years ago by Lottie Greenwood
Merge remote-tracking branch 'origin/bugfixl/1109_less_confusing_file_save_nexus_when_no_ws_selected'
Full changeset: 358c18401b8099b952e99c53429c95936218fbaa
comment:25 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 1957