Ticket #11117 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Parse Poco version and make available in header file

Reported by: Steven Hahn Owned by: Steven Hahn
Priority: critical Milestone: Release 3.4
Component: Framework Keywords:
Cc: Blocked By:
Blocking: #10976 Tester: Pete Peterson

Description

The Poco version is defined as a hex value that cannot be directly used in preprocessor directives. Instead of parsing this value at run time, we will use cmake to configure a header file that defines the major, minor, revision and patch versions at integers.

Change History

comment:1 Changed 6 years ago by Steven Hahn

Refs #11117. Generate header file with Poco version.

Changeset: 9c8a396348e9271cdb52d3d99f0668e3012aa546

comment:2 Changed 6 years ago by Steven Hahn

Refs #11117. clang-format changes to PocoVersion.h.in

Changeset: 340597e03584335653925e087602d94792cdf804

comment:3 Changed 6 years ago by Steven Hahn

Refs #11117. fix lines broken by clang-format

Changeset: ac5934cce72ce9052fe0aadff750b76dbf05d042

comment:4 Changed 6 years ago by Steven Hahn

  • Status changed from new to verify
  • Resolution set to fixed

This is being verified as pull request #242.

comment:5 Changed 6 years ago by Steven Hahn

Refs #11117. replace if statements with more complex regex.

Changeset: 51e7bc512adf2bdc294ebe8eaf159b25177e86fa

comment:6 Changed 6 years ago by Pete Peterson

  • Status changed from verify to verifying
  • Tester set to Pete Peterson

comment:7 Changed 6 years ago by Pete Peterson

I'm happy to merge this, but it is currently showing as a new file in git. There must be some way around that.

comment:8 Changed 6 years ago by Steven Hahn

Refs #11117. Add PocoVersion.h to .gitignore.

Changeset: 831630222215beb77ec2531271792ed1988a0db5

comment:9 Changed 6 years ago by Steven Hahn

PocoVersion.h has been added to .gitignore

comment:10 Changed 6 years ago by Pete Peterson

  • Status changed from verifying to closed

Merge pull request #242 from mantidproject/feature/11117_get_poco_version

Parse Poco version and make available in header file

Full changeset: cab91d0146cfce665b568a9dbbac83a5077f5118

comment:11 Changed 6 years ago by Steven Hahn

Refs #11117. Generate header file with Poco version.

Changeset: 8be0db9c702de01eacc99217ab577ef664a9404a

comment:12 Changed 6 years ago by Steven Hahn

Refs #11117. clang-format changes to PocoVersion.h.in

Changeset: f094e440e5c11a9d5a95504e04b9d3754d53aa78

comment:13 Changed 6 years ago by Steven Hahn

Refs #11117. fix lines broken by clang-format

Changeset: 9ac0c91c5d84d0d21ac924b46a8989b8896d759d

comment:14 Changed 6 years ago by Steven Hahn

Refs #11117. replace if statements with more complex regex.

Changeset: d904ff9d12719708aa67e6ab9536acddf7ec5e4f

comment:15 Changed 5 years ago by Nick Draper

Somehow these slipped through without a resolution. Set to Fixed.

comment:16 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 11956

Note: See TracTickets for help on using tickets.