Ticket #11134 (closed: fixed)
Get rid of unused imports and variables (pylint)
Reported by: | Andrei Savici | Owned by: | Andrei Savici |
---|---|---|---|
Priority: | major | Milestone: | Release 3.4 |
Component: | Python | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Ross Whitfield |
Description
There are 401 unused variables and 353 unused imports reported by pylint
Change History
comment:2 Changed 6 years ago by Andrei Savici
- Status changed from assigned to inprogress
Some pylint warnings. Refs #11134
Changeset: 02c4ff69c586d8b8919e70d46ea26fdded554c73
comment:3 Changed 6 years ago by Andrei Savici
Remove parentheses and fixed continuations. Refs #11134
Changeset: 27cea9acab820dc158c7408d741cf3b19866f0b4
comment:4 Changed 6 years ago by Andrei Savici
removing unused imports from algorithms and functions. Refs #11134
Changeset: 55bd0bd2575b93bf71242fbd42f5f5bbf0e1a9c4
comment:5 Changed 6 years ago by Andrei Savici
Few more. refs #11134
Changeset: c32b1ef4a4d3cddebc9261d8edb3b1b892ba38a3
comment:6 Changed 6 years ago by Andrei Savici
- Status changed from inprogress to verify
- Resolution set to fixed
This is being verified as pull request #260.
comment:7 Changed 6 years ago by Andrei Savici
Update TubeCalibDemoMaps_All.py
undo some line continuations. Refs #11134
Changeset: d89b87a30ec105bbb9ca67a8fcea3009a7cfb30b
comment:8 Changed 6 years ago by Andrei Savici
Update TubeCalibDemoMerlin.py
Refs #11134. Undo some line continuations
Changeset: eeee5797b277bdeb8e09484c9232b5c3795d0089
comment:9 Changed 6 years ago by Andrei Savici
Update TubeCalibDemoWish_Simple.py
Undo some continuations. Refs #11134
Changeset: 4cb27c84bba6c63e13f69ec3fa1a5012efaac074
comment:10 Changed 6 years ago by Andrei Savici
retest this please
comment:11 Changed 6 years ago by Dan Nixon
- Status changed from verify to verifying
- Tester set to Dan Nixon
comment:12 Changed 6 years ago by Dan Nixon
Jenkins, retest this please.
comment:13 Changed 6 years ago by Martyn Gigg
Could you update the pull request title remove the ticket number and capitalise the r in reduce. It would also be easier if the ticket mentioned in the comment had a link to it, following the example [here](http://www.mantidproject.org/Git_Workflow).
comment:14 Changed 6 years ago by Andrei Savici
Refs#11134. Merge branch 'master' into 11134_reducePylintWarnings
Changeset: 768f9492c3c07653357724e073f7cb669fdf56a3
comment:15 Changed 6 years ago by Andrei Savici
Fix conflicts. Refs #11134
Merge remote-tracking branch 'origin/master' into 11134_reducePylintWarnings
Conflicts:
Code/Mantid/Framework/PythonInterface/plugins/algorithms/LoadVesuvio.py Code/Mantid/Framework/PythonInterface/plugins/algorithms/SortDetectors.py Code/Mantid/Framework/PythonInterface/plugins/algorithms/SortXAxis.py Code/Mantid/Framework/PythonInterface/plugins/algorithms/Symmetrise.py Code/Mantid/Framework/PythonInterface/plugins/algorithms/VesuvioResolution.py Code/Mantid/scripts/Inelastic/IndirectAbsCor.py Code/Mantid/scripts/Inelastic/IndirectBayes.py Code/Mantid/scripts/Inelastic/IndirectCommon.py Code/Mantid/scripts/Inelastic/IndirectDataAnalysis.py Code/Mantid/scripts/Inelastic/IndirectNeutron.py
Changeset: aa200bf0de3844e68bd7c11a721ec375aa0d42a0
comment:16 Changed 6 years ago by Andrei Savici
The build fails on a particular machine at ISIS, on a test where it cannot remove /tmp/test_file_for_load_md_histo_workspace_test_.txt. Master builds fail with the same error, only when they are run on isis-mantidlx1
comment:17 Changed 6 years ago by Martyn Gigg
It looks like someone had run the tests on that machine under a different user account, meaning that the file was owned by the other user and not the builder account. I've removed the file.
comment:18 Changed 6 years ago by Martyn Gigg
Jenkins, retest this please.
comment:19 Changed 6 years ago by Andrei Savici
- Status changed from verifying to verify
- Tester Dan Nixon deleted
comment:21 Changed 6 years ago by Ross Whitfield
- Status changed from verify to closed
Merge pull request #260 from mantidproject/11134_reducePylintWarnings
Reduce pylint warnings
Full changeset: 93f2304182ac92cccbb05a20183da78e34ba8208
comment:22 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 11973