Ticket #11136 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

update buildscript.sh for AppleClang

Reported by: Steven Hahn Owned by: Steven Hahn
Priority: major Milestone: Release 3.4
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description

update the buildscript so that it works with clang in the pull request matrix.

Change History

comment:1 Changed 6 years ago by Steven Hahn

Refs #11136. Change how clang build is determined

Changeset: 979fd658b19d44a9cc98230f210f1f919feba238

comment:2 Changed 6 years ago by Steven Hahn

  • Status changed from new to verify
  • Resolution set to fixed

This is being verified as pull request #255.

comment:3 Changed 6 years ago by Pete Peterson

Re #11136. Reworked if/else logic

Changeset: bc84bb9fdd03816f1608b8322386c0cbe265a075

comment:4 Changed 6 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:5 Changed 6 years ago by Martyn Gigg

I think the script looks fine. Despite the green tick though, if you look at the build log for [10.8](http://builds.mantidproject.org/job/pull_requests/640/label=osx-10.8-build/consoleFull) you'll see an error ` /Users/builder/jenkins-linode/workspace/pull_requests/label/osx-10.8-build/Code/Mantid/Build/Jenkins/buildscript: line 29: [[false: command not found `

It looks to me as if in the build of bc84bb9 it has actually built the previous merge. I'll retest it just to be sure.

comment:6 Changed 6 years ago by Martyn Gigg

Jenkins, retest this please

comment:7 Changed 6 years ago by Martyn Gigg

The build failure is on rhel6 and is a problem checking out the pull request. The ubuntu build has covered a Linux environment so I this we can :shipit:

comment:8 Changed 6 years ago by Martyn Gigg

  • Status changed from verifying to closed

Merge pull request #255 from mantidproject/11136_update_buildscript_clang

Change how clang builds are determined

Full changeset: b6076970554a85db1d7191b46123d087812b04dd

comment:9 Changed 5 years ago by Nick Draper

Somehow these slipped through without a resolution. Set to Fixed.

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 11975

Note: See TracTickets for help on using tickets.