CreateGroupingWorkspace fails if number of groups exceeds number of spectra in component

[Dan Nixon]

For example, this call:

grouping_ws = CreateGroupingWorkspace(InstrumentName='IRIS', FixedGroupCount=52, ComponentName='graphite')

gives this error:

fish: Job 1, “./bin/MantidPlot” terminated by signal SIGFPE (Floating point exception)

Because it requests 52 groups but there are only 51 spectra in the graphite component of IRIS.

[Dan Nixon]

Better handle the failure when num groups > num spectra in component

Refs #11140

Changeset: ac0cfd7aa97c4cb0a92121692c1c582eb275eca5

[Dan Nixon]

This is being verified as ​pull request #262.

[Martyn Gigg]

The fix is fine and works as expected.

I tried a negative number for the FixedGroupCount property and it accepted it but created an empty group. I think that, while we are changing the algorithm, it is worth adding a BoundedValidator to the FixedGroupCount property so that it cannot be negative.

[Dan Nixon]

Add bounded validator to keep group count property positive

Refs #11140

Changeset: f24639d32ec59f217a70e419b4ef7a5c887543ab

[Martyn Gigg]

:+1:

[Martyn Gigg]

Merge pull request #262 from mantidproject/11140_creategroupingworkspace_handle_group_count_failure

Handle failure in CreateGroupingWorkspace where group count > spectra count

Full changeset: ​a74480639470b7b3cf0d1ac12fc4a9262ca7b866

[Nick Draper]

Somehow these slipped through without a resolution. Set to Fixed.

[Stuart Campbell]

This ticket has been transferred to github issue ​11979