Ticket #11151 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Fix coverity issues in MantidPlot's PlotDialog

Reported by: Federico M Pouzols Owned by: Federico M Pouzols
Priority: major Milestone: Release 3.4
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Harry Jeffery

Description (last modified by Federico M Pouzols) (diff)

Concerns coverity issues 1075737 (PlotDialog.h) and 1075738-57 (PlotDialog.cpp)

All these issues appear to be unchecked dynamic casts.

Change History

comment:1 Changed 6 years ago by Federico M Pouzols

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Federico M Pouzols

  • Description modified (diff)

comment:3 Changed 6 years ago by Federico Montesino Pouzols

  • Status changed from assigned to inprogress

check dynamic_cast, coverity issue 1075737, re #11151,

Changeset: 37cc588857d6cf83b371b6652888e8a833f5f62c

comment:4 Changed 6 years ago by Federico Montesino Pouzols

dynamic_cast in insertCurvesList, coverity issue 1075738, re #11151,

Changeset: 796addaddaa2554bc85238ecc98c10f6e4018e7e

comment:5 Changed 6 years ago by Federico Montesino Pouzols

dynamic_cast in editCurve, coverity issue 1075739, re #11151,

Changeset: 9896620ac811582173e90f4e6f03ab1057b6d65f

comment:6 Changed 6 years ago by Federico Montesino Pouzols

dynamic_cast, showPlotAssociations, coverity issue 1075740, re #11151

Changeset: d131525e5cfe2d62300d96d85cf64a13891ca671

comment:7 Changed 6 years ago by Federico Montesino Pouzols

dynamic_cast, showPlotAssociations, coverity issue 1075741, re #11151

Changeset: 6f052137b6c5088a5c18b2cf86319da6fa468dc6

comment:8 Changed 6 years ago by Federico Montesino Pouzols

dynamic_casts, showPlotAssociations, coverity issue 1075742, re #11151

Changeset: 17f1f8ca674f8a3e0b0a99997564b62a3e8e234d

comment:9 Changed 6 years ago by Federico Montesino Pouzols

dynamic_cast, setEquidistantLevels, coverity issue 1075743, re #11151

Changeset: 0cbecbf689cee00fbb8fbcd04a82a355689ccb9d

comment:10 Changed 6 years ago by Federico Montesino Pouzols

dynamic_cast, contextMenuEvent, coverity issues 1075744,5, re #11151

Changeset: e1152f9654856154b9d39bbd7cb3f002e0587fbd

comment:11 Changed 6 years ago by Federico Montesino Pouzols

dynamic_cast, chooseLabelsFont, coverity issues 1075746, re #11151

Changeset: bb97b77c17bef5337d3f9af4e978c16921d98d75

comment:12 Changed 6 years ago by Federico Montesino Pouzols

dynamic_casts, updateTabWindow, coverity issues 1075747,8, re #11151

Changeset: d986d3fa13ca16a4b01c4ab62534f610df426f45

comment:13 Changed 6 years ago by Federico Montesino Pouzols

dynamic_casts, setActiveCurve, coverity issues 1075749,51,52 re #11151

Changeset: 9e71e68b123fab1909a693ed06f90c25109b7fc8

comment:14 Changed 6 years ago by Federico Montesino Pouzols

dynamic_cast, showStatistics(), coverity issue 1075750, re #11151

Changeset: ae46dc1ec532248146217e2aeb09e6298eb78f29

comment:15 Changed 6 years ago by Federico Montesino Pouzols

dynamic_cast, changePlotType(), coverity issue 1075753, re #11151

Changeset: 634b3a80c3e87502c0eb93415bdf29787ce24fc6

comment:16 Changed 6 years ago by Federico Montesino Pouzols

dynamic_casts, acceptParams(), coverity issues 1075754, 55, re #11151

Changeset: 040b50a8e92f29ba296e8053ce3eebd17b023fb4

comment:17 Changed 6 years ago by Federico Montesino Pouzols

dynamic_casts, selectCurve(), coverity issues 1075756, re #11151

Changeset: cc146a067a6a0f1955a79f36ad5343dbd4a41327

comment:18 Changed 6 years ago by Federico Montesino Pouzols

dynamic_cast, insertTabs(), coverity issue 1075757, re #11151

Changeset: 089cd0671a4ac6a84e8bdc2be153a66b35e9eb58

comment:19 Changed 6 years ago by Federico M Pouzols

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #288.

comment:20 Changed 6 years ago by Harry Jeffery

  • Status changed from verify to verifying
  • Tester set to Harry Jeffery

comment:21 Changed 6 years ago by Harry Jeffery

  • Status changed from verifying to closed

Merge pull request #288 from mantidproject/11151_fix_coverity_issues_MantidPlot_PlotDialog

Fix coverity issues in MantidPlot's PlotDialog

Full changeset: ​5d5e645320b90ba8448fb7497e10659816743a71

comment:22 Changed 5 years ago by Nick Draper

Somehow these slipped through without a resolution. Set to Fixed.

comment:23 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11990

Note: See TracTickets for help on using tickets.