Ticket #11155 (closed)

Opened 6 years ago

Last modified 5 years ago

Fix ISIS direct GUI failing due to changes in direct reduction scripts

Reported by: Alex Buts Owned by: Alex Buts
Priority: major Milestone: Release 3.4
Component: Direct Inelastic Keywords:
Cc: Blocked By: #11063, #11096
Blocking: Tester: Roman Tolchenov

Description


Change History

comment:1 Changed 6 years ago by Alex Buts

  • Status changed from new to assigned
  • Blocked By 11063, 11096 added

comment:2 Changed 6 years ago by Alex Buts

  • Blocking 11155 added
  • Blocked By 11155 added

comment:3 Changed 6 years ago by Alex Buts

  • Status changed from assigned to inprogress
  • Component changed from Framework to User Interface
  • Blocking 11155 removed
  • Blocked By 11155 removed
  • Milestone set to Release 3.4

comment:4 Changed 6 years ago by Alex Buts

Re #11155 Changes to python script and parameters files

allowing to run the script from GUI.

Changeset: 3351b3d23a0d55bbb6b87c6b14d34a8d453d2b33

comment:5 Changed 6 years ago by Alex Buts

Re #11155 final fix for GUI to work

Changeset: de603f23b4502e9a5bc084b2daa8bad274c1a02f

comment:6 Changed 6 years ago by Alex Buts

Re #11155 Avoid system test failure if test files are accumulated.

(delete these files)

Changeset: 996ded5181deab5d3cc041133393c4267352145d

comment:7 Changed 6 years ago by Alex Buts

this fixed by PR ​https://github.com/mantidproject/mantid/pull/519

Apparently fixing GUI appears to be possible by minor changes to python only. As nobody actually uses this GUI, I did not tried to improve GUI interaction with the script -- just made changes necessary for it to work in current state, so the changes appeared to be Python only. (beating the expectations that it would be C++)

To test, verify that workflow, described in http://www.mantidproject.org/Direct:ConvertToEnergy#Basic_Reduction works.

Two things should be noted:

1) Reduction does not work without vanadium (number 11060 always has to be inserted into appropriate field) This is desired behaviour, so no point to force it to work differently

2) For it to work without maps, one has to provide None in the Map File field (this is because configuration defaults, described in MAPS_Parameters.xml file have changed.

I tried to change the documentation, but the system does not accept my changes to pictures. (Though I have uploaded number of changed images) This may be separate issue, but I am not pursuing it due to low importance of the GUI. Nobody actually uses it anyway.

Last edited 6 years ago by Alex Buts (previous) (diff)

comment:8 Changed 6 years ago by Roman Tolchenov

  • Status changed from inprogress to verifying
  • Tester set to Roman Tolchenov

comment:9 Changed 6 years ago by Roman Tolchenov

Get the error: ` KeyError: ' Property name: motor_name is not defined'

at line 13 in '<Interface>' caused by line 180 in 'C:/Users/hqs74821/Work/mantid_test/Code/Mantid/scripts/Inelastic\Direct\PropertyManager.py' caused by line 259 in 'C:/Users/hqs74821/Work/mantid_test/Code/Mantid/scripts/Inelastic\Direct\ReductionHelpers.py'

`

comment:10 Changed 6 years ago by Roman Tolchenov

  • Status changed from verifying to closed

Merge pull request #519 from mantidproject/11155_DirectInelasticGUI

Fixing direct inelastic GUI

Full changeset: ​db38e615968525dc98f9903ce92010566ca85362

comment:11 Changed 5 years ago by Nick Draper

  • Component changed from User Interface to Direct Inelastic

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11994

Note: See TracTickets for help on using tickets.