Ticket #11177 (closed: fixed)
Enable Rotation angle in ISIS Direct inelastic
Reported by: | Alex Buts | Owned by: | Alex Buts |
---|---|---|---|
Priority: | major | Milestone: | |
Component: | Direct Inelastic | Keywords: | |
Cc: | Blocked By: | #11063, #11096 | |
Blocking: | Tester: | Federico M Pouzols |
Description
Change History
comment:3 Changed 6 years ago by Alex Buts
- Status changed from assigned to inprogress
Re #11177 Initial commit (Bulk code not checked)
+ workspace parameters
Changeset: 9d9c7b7caac62092961fe9604d3c2ac0f2406d58
comment:4 Changed 6 years ago by Alex Buts
Re #11177 Defined psi property and unit test to verify it
Changeset: aadb2257a527c6d0ac5b6fb61cfac69a902f5a3a
comment:5 Changed 6 years ago by Alex Buts
Re #11177 Reformatted DirectEnergyConversion a bit
to decrease pylint warnings and increase code separation. Rotation fails
Changeset: 8df665f0b7cf0145ee67d08593b3060e63c1af0f
comment:6 Changed 6 years ago by Alex Buts
Re #11177 This should do. Rearranged a bit of code according to pylint
and mainly fixed bugs, induced by this rearrangement. All seems OK
Changeset: 452b909eceeee94022709f774c53ec946912cf4b
comment:7 Changed 6 years ago by Alex Buts
Re #11177 Merge branch '11177_ISIS_RotationAngle' into develop
Conflicts:
Code/Mantid/scripts/Inelastic/Direct/DirectEnergyConversion.py Code/Mantid/scripts/Inelastic/Direct/NonIDF_Properties.py Code/Mantid/scripts/Inelastic/Direct/PropertiesDescriptors.py
Changeset: e49899544fb060aecfbc3dd7bd47bc2e4c01806e
comment:8 Changed 6 years ago by Alex Buts
Re #11177 Minor bug in Monitor ws name
Changeset: 56f380c5f4509ab8f5d6ce519aa898695996bf84
comment:9 Changed 6 years ago by Alex Buts
Re #11177 Suble bug in ReductionWrapper
(and a lot of pylint changes)
Changeset: 4f72bbd7015352c45af5bca3c7824646ad5db043
comment:10 Changed 6 years ago by Alex Buts
Re #11177 Merge branch '11177_ISIS_RotationAngle' into develop
Conflicts:
Code/Mantid/scripts/Inelastic/Direct/RunDescriptor.py
Changeset: 693d18cbd59f03d76780985e34cbef23dda64046
comment:11 Changed 6 years ago by Alex Buts
Re #11177 minor comments
Changeset: 9ace36b4ef30844b4e4164bb9904d042144bed38
comment:12 Changed 6 years ago by Alex Buts
- Status changed from inprogress to verify
- Resolution set to fixed
comment:13 Changed 6 years ago by Alex Buts
Re #11177 Should fix system test over number of parameters
two new have been recently added describing rotation
Changeset: 9a852a1fc111ccefd94b93fbbc0d82fc252125b7
comment:14 Changed 6 years ago by Alex Buts
Re #11177 73 parameters for instrument parameters
Strange, who 73, I've added 2 which should be 2 more to previous value 72. But it is what test says so let's see.
Changeset: 0473de79e80c3cf312113ab61c1c94fe60f19abf
comment:15 Changed 6 years ago by Alex Buts
this is fixed as pool request https://github.com/mantidproject/mantid/pull/315
comment:16 Changed 6 years ago by Alex Buts
Re #11177 Fixed bug induced by Pylint changes
Changeset: 525ec35013a052b0bcc786f4c799866ace15103e
comment:17 Changed 6 years ago by Dan Nixon
- Status changed from verify to verifying
- Tester set to Dan Nixon
comment:18 Changed 6 years ago by Alex Buts
Re #11177 Two more pylint induced bugs
which should be identified by system tests but did not.
Changeset: 4753da3e26009191faab7199ebe31bab051f10f3
comment:19 Changed 6 years ago by Federico M Pouzols
Jenkins, retest this please
comment:20 Changed 6 years ago by Federico M Pouzols
Jenkins, retest this please.
comment:21 Changed 6 years ago by Federico M Pouzols
- Tester changed from Dan Nixon to Federico M Pouzols
comment:22 Changed 6 years ago by Federico M Pouzols
This seems to be ready to be merged in. I'm passing the system tests locally now...
comment:23 Changed 6 years ago by Federico M Pouzols
All unit tests passed, and also all the system tests that I could run stretching my available RAM (including the ISISDirectInelastic tests).
comment:24 Changed 6 years ago by Federico M Pouzols
- Status changed from verifying to closed
Merge pull request #315 from mantidproject/11177_ISIS_RotationAngle
Code to calculate rotation angle from sample logs during reduction (ISIS)
Full changeset: dc59cb265a6e8e03cc7deeb7e4030ef470ba4fa9
comment:25 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 12016