Ticket #11184 (closed: fixed)
Allow plus created event file to be processed with ISIS SANS
Reported by: | Anders Markvardsen | Owned by: | Peter Parker |
---|---|---|---|
Priority: | critical | Milestone: | Release 3.4 |
Component: | SANS | Keywords: | |
Cc: | peter.parker@…, sarah.rogers@…, anton.piccardo-selg@… | Blocked By: | #11351 |
Blocking: | Tester: | Martyn Gigg |
Description (last modified by Anders Markvardsen) (diff)
Take e.g. the SANS2D event runs 26995 and 27019 and add these together, but not adding these into a histogram workspace file. Instead into an event workspace file that can then subsequently be processed with the ISIS SANS interface in the same way as a standard event nexus file.
Attachments
Change History
comment:2 Changed 6 years ago by Anders Markvardsen
- Description modified (diff)
From meeting earlier this week. Hard deadline is end of April for this feature.
Steps to implement this.
- Run e.g. SANS2D 26995 insuring that monitors are loaded
- Put the two created workspaces into a group, monitors and event data and save this group as a processed mantid nexus workspace
- Monitor the sans code so that when doing the initial loading the workspaces you get from loading 2) exactly same loading from 1). Then the remaining code can stay the same.
comment:4 Changed 6 years ago by Anders Markvardsen
- Owner changed from Anders Markvardsen to Peter Parker
comment:5 Changed 6 years ago by Peter Parker
- Cc anton.piccardo-selg@… added
- Status changed from assigned to verify
- Resolution set to invalid
Sarah:
After some further investigation / discussion surrounding this ticket, we've come to the conclusion that this functionality is actually already available in Mantid, albeit not using the "Add Runs" tab of the ISIS SANS interface:
- Load the Event files you want to add (using the Load algorithm and not the "Load Data" button of the interface).
- Use the Plus algorithm to add the event workspaces together. Obviously if you have more than 2 files it's going to require multiple calls to Plus.
- Save the result to file by right-clicking the workspace and pressing "Save Nexus". Make sure to name the file as per the "Add Runs" tab's naming convention (i.e. "SANS2DNNNNNNN-add.nxs").
We've tried this with 26995 and 27019 and the resulting file goes through the reducer well enough.
In the meantime, we have #11351 to allow this to work as part of the "Add Runs" tab. Anton and I will be looking into this tomorrow. We will get back to you when we've implemented it.
comment:6 Changed 6 years ago by Anders Markvardsen
- Status changed from verify to verifying
- Tester set to Anders Markvardsen
comment:7 Changed 6 years ago by Anders Markvardsen
- Status changed from verifying to reopened
- Resolution invalid deleted
Doing the following:
I used user file: C:/Backup/Backup_folder1/work/code/Mantid/git/mantid2/Test/systemtests/Data/SANS2D/MASKSANS2D.091A
- Load
isis\inst$\NDXSANS2D\Instrument\data\cycle_14_2\SANS2D00026995.nxs without the Load diaglog LoadMonitors tick-box ticked generates one event workspace SANS2D00026995. However right clicking and selecting 'Show detectors', there are no monitor data
- Repeating the above I with LoadMonitors tick-box ticked at I get two workspaces
- Jointly with Anton I can't reproduce the above results. I.e. loading using steps in 1 for both 26995 and 27019, etc, and my Mantid version is not happy.
I spoke to Sarah and she says, to her knowledge the monitor data are stored as histogram data.
If the LoadMonitors is not ticked I struggle to see how the save nexus file can contain monitor data. If this is the case it is a bug
Peter/Anton please try this a second time
comment:8 Changed 6 years ago by Peter Parker
Apologies everyone, this was a misunderstanding on my part. We'll look into this again today.
comment:9 Changed 5 years ago by Anton Piccardo-Selg
- Status changed from reopened to inprogress
Refs #11184 Accept added event data in SANS interface
Changeset: bfb3911e7bb771bd06ede00fd7bda6c73af76fa9
comment:10 Changed 5 years ago by Anton Piccardo-Selg
Refs #11184 Make unit tests in sans utility work
Changeset: 5499b5f48c391d3ece5e59c23e6632f977077e93
comment:11 Changed 5 years ago by Anton Piccardo-Selg
Refs #11184 Adding system and unit tests
Changeset: 20c8a3e3cc9df0fa6991b4a6c2c73ec6ec1a4fa9
comment:12 Changed 5 years ago by Anton Piccardo-Selg
Refs #11184 workaround for bad workspace history
Changeset: 02104b2a69dde4f3e99100eba2ad77032f28d7a7
comment:13 Changed 5 years ago by Anton Piccardo-Selg
Refs #11184 Get system tests to validate and clean up
Changeset: 85c8ca1626b575f8d0637d1aa7f5978009aac0b9
comment:14 Changed 5 years ago by Anton Piccardo-Selg
Refs #11184 Resolve merge issues
Changeset: 7e5e2c502e63075c6f5ed60a5dc6458edea1ddbe
comment:15 Changed 5 years ago by Anton Piccardo-Selg
Refs #11184 fix regex strings and tests
Changeset: ef40e61d7353b8fa1b2abefd343cc80f570ebddd
comment:16 Changed 5 years ago by Anton Piccardo-Selg
Refs #11184 Remove system test for now
Changeset: 83e36bed6a14c724d49ac30ed03be730af6fb46f
comment:17 Changed 5 years ago by Anton Piccardo-Selg
- Status changed from inprogress to verify
- Resolution set to fixed
This is being verified as pull request #667.
comment:18 Changed 5 years ago by Anton Piccardo-Selg
Refs #11184 fix loader name
Changeset: 4fd6431712613f390c4e7e66c46e8080f2fd2f19
comment:19 Changed 5 years ago by Anton Piccardo-Selg
Refs #11184 bring back old loader name
Changeset: 35670e39d074349509d1d694001de7398ea2b06a
comment:20 Changed 5 years ago by Anton Piccardo-Selg
Refs #11184 fix unit test for rhel
Changeset: e7a5911509ae398f00f884e6c550a77bb472c351
comment:21 Changed 5 years ago by Anton Piccardo-Selg
Refs #11184 fix pylint issues
Changeset: e13718db651d9707e55b95888eb267d7d4fd5ef7
comment:24 Changed 5 years ago by Anton Piccardo-Selg
Refs #11184 catch exception when using renamed workspaces
Changeset: 6dc6b578814e9f63b1372e2d806d8d195a3f3862
comment:25 Changed 5 years ago by Anton Piccardo-Selg
Refs #11184 declare loader name
Changeset: 818fb16af5498018e77a43cd27ded17c4ee4b3ba
comment:26 Changed 5 years ago by Anton Piccardo-Selg
Refs #11184 correct add_runs in system test
Changeset: e7f89f5f96c6a80c37aae182bd0c8aa14b7e86f1
comment:27 Changed 5 years ago by Anton Piccardo-Selg
Refs #11184 Resolve merge conflicts
Changeset: 3dcf52ee41c0ef572c739cce00069eeb546c9355
comment:28 Changed 5 years ago by Anton Piccardo-Selg
Refs #11184 integrate system test
Changeset: f4fd99df10aaff118920f82fb374ed0fc2666a6d
comment:29 Changed 5 years ago by Anton Piccardo-Selg
Refs #11184 Fix unit test
Changeset: 89c8d36e5a7b163ed4f563d2e5f497ef4789f3d0
comment:30 Changed 5 years ago by Anton Piccardo-Selg
Refs #11184 resolve config issue
Changeset: 477f70b63bd28f6ac40337a88db7be447f2cfab8
comment:31 Changed 5 years ago by Anton Piccardo-Selg
Refs #11184 Pylint fixes
Changeset: 1b40313b8e43ca9a40ef79f77b953fbbaa163b53
comment:32 Changed 5 years ago by Anton Piccardo-Selg
Refs #11184 add init to remove pylint
Changeset: bf884f7a269eeab11c4522267f1921822e1c3eb2
comment:33 Changed 5 years ago by Anton Piccardo-Selg
Refs #11184 Add system test data for added event loading in SANS
Changeset: 91fbdbd9f7b20e132f7392b1f18946ea68dad518
comment:34 Changed 5 years ago by Anton Piccardo-Selg
Refs #11184 further pylint fixes
Changeset: 2ff8a532d7d02d4669d7be675ca286e2d2c935bd
Changed 5 years ago by Anton Piccardo-Selg
- Attachment USER_SANS2D_143AB_5_12m_Xpress_M3_8mm.txt added
Changed 5 years ago by Anton Piccardo-Selg
- Attachment DIRECT_SANS2d_27511_12m_Rear_23Mar15.txt added
comment:35 Changed 5 years ago by Martyn Gigg
- Status changed from verify to verifying
- Tester changed from Anders Markvardsen to Martyn Gigg
comment:36 Changed 5 years ago by Martyn Gigg
- Status changed from verifying to closed
Merge pull request #667 from mantidproject/feature/11184_load_added_event_data_as_event_data
Load added event data as event data in ISIS SANS GUI
Full changeset: bccfbaa710f93714240a6af7c918521dba88b74c
comment:37 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 12023