Ticket #11211 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

CalibrateRectangularDetectors system test is broken

Reported by: Martyn Gigg Owned by: Peter Peterson
Priority: critical Milestone: Release 3.4
Component: Diffraction Keywords:
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description

The stack trace from the test

FrameworkManager-[Notice] Welcome to Mantid 3.3.20150302.2302
FrameworkManager-[Notice] Please cite: http://dx.doi.org/10.1016/j.nima.2014.07.029 and this release: http://dx.doi.org/10.5286/Software/Mantid
CalibrateRectangularDetectors-[Notice] CalibrateRectangularDetectors started
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/home/builder/Jenkins/workspace/master_systemtests/label/rhel6/StressTestFramework/stresstesting.py", line 198, in execute
    self.runTest()
  File "/home/builder/Jenkins/workspace/master_systemtests/label/rhel6/SystemTests/AnalysisTests/CalibrateRectangularDetector_Test.py", line 88, in runTest
    CrossCorrelation = True, Instrument = 'PG3', RunNumber = '2538', Extension = '_event.nxs')
  File "/opt/mantidnightly/bin/mantid/simpleapi.py", line 575, in algorithm_wrapper
    algm.execute()
RuntimeError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()
  at line 142 in '/opt/mantidnightly/plugins/python/algorithms/CalibrateRectangularDetectors.py'}}}

It looks like the {{{DetectorsPeaks}}} property is now a proper numpy array not a string so {{{bool(detectors)}}} won't work.

Change History

comment:1 Changed 6 years ago by Pete Peterson

  • Status changed from new to inprogress

Re #11211. This should fix the system test.

Changeset: 9c46e038896f3499c67a213b9087cc86ae3680f5

comment:2 Changed 6 years ago by Pete Peterson

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as pull request #337.

comment:3 Changed 6 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:4 Changed 6 years ago by Federico M Pouzols

Jenkins, retest this please

comment:5 Changed 6 years ago by Martyn Gigg

  • Status changed from verifying to closed

Merge pull request #337 from mantidproject/11211_calib_rect_systest

Fix CalibrateRectangularDetectors system test

Full changeset: 5cdfa35798eba4cf7d85068224acf135df853d9a

comment:6 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 12050

Note: See TracTickets for help on using tickets.