Ticket #11216 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Bugfix: Remove Cppcheck warnings that were introduced by Remove Rebinning

Reported by: Anton Piccardo-Selg Owned by:
Priority: major Milestone: Release 3.4
Component: GUI Keywords: VATES
Cc: Blocked By:
Blocking: Tester: Andrei Savici

Description

Several cppCheck errors were not detected when Remove Rebinning from VSI was merged into the master.

Attachments

MDEvent1.nxs​ (2.3 MB) - added by Anton Piccardo-Selg 6 years ago.

Change History

comment:1 Changed 6 years ago by Anton Piccardo-Selg

  • Status changed from new to inprogress

Refs #11216 Fix for cppcheck errors

Changeset: 49ee0e8da2da613905cdf194b28207dfb17a9af4

comment:2 Changed 6 years ago by Anton Piccardo-Selg

For testing:

Fixes for the cppCheck errors were applied.

  • Load the attached MDEvent workspace into the VSI. Switch into the Standard View
  • Press "Scale" and press "Apply"
  • Press rebin and select BinMD. Leave the settings and press ok
  • Remove the rebinning (option in the rebin button)
  • Confirm that there is no exception

Changed 6 years ago by Anton Piccardo-Selg

comment:3 Changed 6 years ago by Anton Piccardo-Selg

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #339.

comment:4 Changed 6 years ago by Anton Piccardo-Selg

Jenkins, retest this please

comment:5 Changed 6 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester set to Andrei Savici

comment:6 Changed 6 years ago by Andrei Savici

  • Status changed from verifying to closed

Merge pull request #339 from mantidproject/feature/11216_fix_cppcheck_from_rebin_vsi

Fix for cppcheck errors caused by Remove RebinningCutter in VSI

Full changeset: ​c5a76a0d5d89477fdff0d1aa0a09658422b0182c

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​12056

Note: See TracTickets for help on using tickets.