Ticket #11262 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Bugfix: Fix a cppcheck error in the MDPlottingCmapsProvider

Reported by: Anton Piccardo-Selg Owned by:
Priority: major Milestone: Backlog
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Raquel Alvarez

Description

We need to resolve the cppcheck error caused by the MDPlottingCmapsProvider

Change History

comment:1 Changed 6 years ago by Anton Piccardo-Selg

  • Status changed from new to inprogress

Refs #11262 Fix cppcheck issue

Changeset: 96bf3d06716d4c3b9fc64497331c76eee2339362

comment:2 Changed 6 years ago by Anton Piccardo-Selg

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #350.

comment:3 Changed 6 years ago by Anton Piccardo-Selg

For Testing

Code review is sufficient

comment:4 Changed 6 years ago by Martyn Gigg

Could you remove the ticket reference from the pull request title and put include the test instructions in the pull request description. We are trying to follow the template described in http://www.mantidproject.org/Git_Workflow#Pull_Requests. Thanks

comment:5 Changed 6 years ago by Anton Piccardo-Selg

  • Summary changed from Fix a cppcheck error in the MDPlottingCmapsProvider to Bugfix: Fix a cppcheck error in the MDPlottingCmapsProvider

comment:6 Changed 6 years ago by Anton Piccardo-Selg

Jenkins, retest this please

comment:7 Changed 6 years ago by Anton Piccardo-Selg

Jenkins, retest this please

comment:8 Changed 6 years ago by Raquel Alvarez

  • Status changed from verify to verifying
  • Tester set to Raquel Alvarez

comment:9 Changed 6 years ago by Raquel Alvarez

  • Status changed from verifying to closed

Merge pull request #350 from mantidproject/feature/11262_fix_cppcheck_error_caused_by_MDPlottingCmapsProvider

Fix cppcheck issue caused by the MDPlottingCmapsProvider

Full changeset: ​5f6dcf81a56c768e3df646ce932d709506ea5138

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​12101

Note: See TracTickets for help on using tickets.