Ticket #11281 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Cppcheck warning in CorelliCrossCorrelate

Reported by: Ross Whitfield Owned by: Ross Whitfield
Priority: minor Milestone: Release 3.4
Component: Diffraction Keywords:
Cc: Blocked By:
Blocking: Tester: Andrei Savici

Description

cppcheck v1.68 warns about "Consecutive return, break, continue, goto or throw statements are unnecessary. The second statement can never be executed, and so should be removed." in Framework/Algorithms/src/CorelliCrossCorrelate.cpp" line="209".

Change History

comment:1 Changed 6 years ago by Ross Whitfield

  • Status changed from new to inprogress

Refs #11281 Fixed cppcheck warning

by removing case, as EventType is checked in validateInputs.

Changeset: c68f8645ffc52f00d4e910550efffe87e8c06d02

comment:2 Changed 6 years ago by Ross Whitfield

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #361.

comment:3 Changed 6 years ago by Ross Whitfield

  • Status changed from verify to verifying
  • Tester set to Ross Whitfield

comment:4 Changed 6 years ago by Ross Whitfield

  • Status changed from verifying to verify
  • Tester Ross Whitfield deleted

comment:5 Changed 6 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester set to Andrei Savici

comment:6 Changed 6 years ago by Andrei Savici

  • Status changed from verifying to closed

Merge pull request #361 from mantidproject/11281_CorelliCC_cppcheck

Fix cppcheck warning in CorelliCrossCorrelate

Full changeset: ​c839cfbc1ed5f786d564b6b0ba980f0c58882bfd

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​12120

Note: See TracTickets for help on using tickets.