Ticket #11323 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Fix remaining coverity issues in MantidPlot / Graph.cpp + Cppcheck issues (1.68)

Reported by: Federico M Pouzols Owned by: Federico M Pouzols
Priority: major Milestone: Release 3.4
Component: Framework Keywords: Coverity
Cc: Blocked By:
Blocking: Tester: Andrei Savici

Description (last modified by Federico M Pouzols) (diff)

After #11152, coverity now reports 3 issues in Graph.cpp. Fix them.

As a bonus, fix three issues identified by Cppcheck (1.68) in Graph.cpp (the three are postfixOperator): ​http://builds.mantidproject.org/view/Static%20Analysis/job/cppcheck-1.68/

Change History

comment:1 Changed 6 years ago by Federico M Pouzols

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Federico M Pouzols

  • Description modified (diff)
  • Summary changed from Fix remaining coverity issues in MantidPlot / Graph.cpp to Fix remaining coverity issues in MantidPlot / Graph.cpp + Cppcheck issues (1.68)

comment:3 Changed 6 years ago by Federico Montesino Pouzols

  • Status changed from assigned to inprogress

fix cppcheck 1.68 issues (postfixOperator perf) in Graph, re #11323

Changeset: 03ae318bf10943b95ec44badef712b3d748324db

comment:4 Changed 6 years ago by Federico Montesino Pouzols

fix coverity issue 1075813, potential null deref, re #11323

Changeset: 080e98a964d4bd2d49f0ae0f3daba81ae0d40a4c

comment:5 Changed 6 years ago by Federico Montesino Pouzols

fix coverity issue 1075810, dynamic_cast, re #11323

Changeset: b9d77edd7b3d174fc71c38408cd0680b63be92b6

comment:6 Changed 6 years ago by Federico Montesino Pouzols

fix coverity issue 1075798, null deref, re #11323

Changeset: c2cac000178d6c42f82c27f38724d4e38de2d208

comment:7 Changed 6 years ago by Federico Montesino Pouzols

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #380.

comment:8 Changed 6 years ago by Federico M Pouzols

  • Keywords Coverity added

comment:9 Changed 6 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester set to Andrei Savici

comment:10 Changed 6 years ago by Andrei Savici

  • Status changed from verifying to closed

Merge pull request #380 from mantidproject/11323_fix_remaining_coverity_issues_Graph_cpp_and_new_cppcheck_issues

Fix remaining coverity issues in MantidPlot/Graph (+ new cppcheck 1.68 issues)

Full changeset: ​d7381b26d799d3606f123a1f2e120724723996c8

comment:11 Changed 5 years ago by Nick Draper

Somehow these slipped through without a resolution. Set to Fixed.

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​12162

Note: See TracTickets for help on using tickets.